rc_update: fix on-off-switch with negative threshold values #21796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channel values stay over one unit test but some tests assumed they are reset each time. Reset the channel after these mode button tests. Parameters survive between unit tests presumably as long as the bianry runs. Reset them if a test requires that.
MaEtUgR
force-pushed
the
maetugr/rc-update-test
branch
from
e20b3b6
to
ad72d05
Compare
junwoo091400
reviewed
Jul 3, 2023
|
I made a minimal bugfix port for the 1.14 release: #21801 |
junwoo091400
requested changes
Jul 4, 2023
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-community-q-a-july-05-2023/32963/1 |
Co-authored-by: Junwoo Hwang <junwoo091400@gmail.com>
junwoo091400
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When reviewing #21763 I wasn't exactly sure why the fix is needed at all see #21763 (comment). I tested on hardware and realized it's actually broken and I still don't know why it broke. But I was sure I wanted it to not break the same way again and the function to be more readable. So I added unit testing and fixed it by simplifying the function rather than adding to it.
Fixes #19809
Closes #21763
Solution
Changelog Entry
Test coverage
Unit tests that I added. I can also test on hardware if desired.