-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc_update: fix on-off-switch with negative threshold values #21796
Conversation
Channel values stay over one unit test but some tests assumed they are reset each time. Reset the channel after these mode button tests. Parameters survive between unit tests presumably as long as the bianry runs. Reset them if a test requires that.
e20b3b6
to
ad72d05
Compare
I made a minimal bugfix port for the 1.14 release: #21801 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems nice, thanks for this follow-up PR! Let's get this in main
, then into 1.14
🔥
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-community-q-a-july-05-2023/32963/1 |
Co-authored-by: Junwoo Hwang <junwoo091400@gmail.com>
Solved Problem
When reviewing #21763 I wasn't exactly sure why the fix is needed at all see #21763 (comment). I tested on hardware and realized it's actually broken and I still don't know why it broke. But I was sure I wanted it to not break the same way again and the function to be more readable. So I added unit testing and fixed it by simplifying the function rather than adding to it.
Fixes #19809
Closes #21763
Solution
Changelog Entry
Test coverage
Unit tests that I added. I can also test on hardware if desired.