Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc_update: fix on-off-switch with negative threshold values #21796

Merged
merged 6 commits into from
Jul 11, 2023
Merged

rc_update: fix on-off-switch with negative threshold values #21796

merged 6 commits into from
Jul 11, 2023

Commits on Jun 30, 2023

  1. rc_update: switch back to protected scope and use fixture for testing

    @MaEtUgR
    MaEtUgR committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    415ddbf View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. rc_update: extend ModuleParams::updateParams() for local parameter up… 

    …dates
    @MaEtUgR
    MaEtUgR committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    76289d9 View commit details
    Browse the repository at this point in the history

  2. RCUpdateTest: fix unit test parameters + restoring state after test 

    Channel values stay over one unit test but some tests assumed they are
reset each time. Reset the channel after these mode button tests.

Parameters survive between unit tests presumably as long as
the bianry runs. Reset them if a test requires that.
    @MaEtUgR
    MaEtUgR committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    1c41dc6 View commit details
    Browse the repository at this point in the history

  3. RCUpdateTest: add unit test for return switch

    @MaEtUgR
    MaEtUgR committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    45f960c View commit details
    Browse the repository at this point in the history

  4. rc_update: fix on-off-switch with negative threshold values

    @MaEtUgR
    MaEtUgR committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ad72d05 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. RCUpdateTest: RC switch correct corner case test value 

    Co-authored-by: Junwoo Hwang <junwoo091400@gmail.com>
    @MaEtUgR @junwoo091400
    MaEtUgR and junwoo091400 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e1b8f4f View commit details
    Browse the repository at this point in the history