Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.14 backport] mag_cal: fix mag bias estimate to mag cal #21835

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

dagar
Copy link
Member

@dagar dagar commented Jul 11, 2023

Minimal cherry-pick of #21812 for v1.14.

@bresch

- since last_us is set to 0 every time the bias is not observable, the
  total time was also reset -> needed 30 consecutive seconds in mag 3D
  to be declared "stable"
- after landing, the mag_aligned_in_flight flag is reset. Using this for
  bias validity makes it invalid before we have a chance to save it to
  the calibration.
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@junwoo091400 junwoo091400 changed the title mag_cal: fix mag bias estimate to mag cal [v1.14 backport] mag_cal: fix mag bias estimate to mag cal Jul 18, 2023
@mrpollo mrpollo merged commit 6103659 into release/1.14 Jul 18, 2023
2 checks passed
@mrpollo mrpollo deleted the pr-in_flight_mag_cal_fix_backport branch July 18, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants