GH Actions - MAVROS fix #23377
Merged
GH Actions - MAVROS fix #23377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudio-Chies
force-pushed
the
pr-test_fix
branch
from
adbcb88
to
ce1fc5e
Compare
Claudio-Chies
force-pushed
the
pr-test_fix
branch
from
ce1fc5e
to
088c0b0
Compare
sfuhrer
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Seems to do it, thanks a lot for taking care @Claudio-Chies !
@dagar do you want to have a last look?
dagar
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The Github Actions tests for the two MAVROS tasks were failing
Solution
Allowed unsecure NODE versions, see actions/checkout#1809
Alternatives
We'll have to find a more permanent solution, mabye switch the docker containers over to ROS2 Jazzy Jalisco
as the distro for the current container has reached EOL one year ago.