Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapdragon cmake fixes #9493

Closed
wants to merge 1 commit into from
Closed

snapdragon cmake fixes #9493

wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented May 21, 2018


int putchar(int character)
{
PX4_ERR("Error: Calling unresolved symbol stub:[%s]", __FUNCTION__);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar I just talked to @bkueng about this and he had some concerns about this implementation.
Specifically how can we be sure that PX4_ERR (which uses printf) does not end up calling putchar again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it's a bit questionable. I don't have a full understanding of how this symbol resolution is expected to work qurt side.

@dagar
Copy link
Member Author

dagar commented May 22, 2018

Continued in #9503

@dagar dagar closed this May 22, 2018
@dagar dagar deleted the pr-snapdragon_cmake branch January 23, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants