-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency and FAQs #2
Conversation
Consistency - Use `-` for no available packages. Easier on the eyes. - bioconda lowercase if not at start of sentence. - *-Packages Clarify conflicts of `pb-dazzler` FAQ: No PacBio tech support. Use issue tracker FAQ: Clarify which tool version to use, bioconda vs SMRT Analysis.
README.md
Outdated
## Availability | ||
|
||
**Notes:** | ||
* Python packages require version 2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's fine. But I'd like to track which packages already work with py3. Hmmm...
... I think we need an Issue. There, we can use check-boxes to track our work on py3-compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add a link to your issue
Actually, someone updated Unfortunately, we cannot do that for DALGINER/etc because we do not actually own those. So we need a check in Falcon to test early whether we have our own daligner suite.. |
Btw, I learned something annoying when I looked into the
Unfortunately, commit/version goes into the directory name within the tarball. (And in fact, the directory name does not match the tarball filename; rather, it is prefixed with the repo name. But that's not the problem.) So these 2 100% identical source distributions have different sha256 checksums. That makes equivalence hard to prove. But I did verify it myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Does my comment in python versions appear in this review. Let's see...)
README.md
Outdated
@@ -112,5 +124,13 @@ There are no plans to provide darwin binaries for packages currently missing Mac | |||
There are no plans to provide executables for Windows. | |||
We do not provide support for WSL (Windows Subsystem for Linux). | |||
|
|||
### Which version of tool X shall I use, from bioconda or from SMRT Analysis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your usage of "SMRT Analysis" is confusing to me. "SMRT Analysis" is a subcomponent of SMRT Link. Similarly, "smrt-tools" is a subcomponent of "SMRT Link" that is used by several other subcomponents (e.g., SMRT Analysis, RunQC).
"SMRT Analysis build" is an RS-era construct. There is no (or there shouldn't be) a formal SMRT Analysis (only) build. There are only "SMRT Link" and "SMRT Link tools" builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Will push a fix
4de4116
to
f88c36f
Compare
Remember to click "Delete branch" after merging, if desired. |
Yeah, in bitbucket I have the checkbox activated per default :) Thanks for the reminder |
Consistency
-
for no available packages. Easier on the eyes.Clarify conflicts of
pb-dazzler
FAQ: No PacBio tech support. Use issue tracker
FAQ: Clarify which tool version to use, bioconda vs SMRT Analysis.