Dev 76: Be able to set a property (like attr.fill) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjones-plip
suggested changes
Jul 11, 2018
| @@ -257,6 +257,21 @@ For example, if we want to have countries background color to be related to a sc | |||
| } | |||
| ``` | |||
|
|
|||
| The value can also be a function that have a parameter a `groupedData` and returns the value. You can define your own logic to generate the attribute value, for example: | |||
There was a problem hiding this comment.
yay for keeping the docs up to date. thanks!
| @@ -1,4 +1,4 @@ | |||
| /* MapTable 1.5.3 */this.d3 = this.d3 || {}; | |||
There was a problem hiding this comment.
per my other comment, let's keep this in here so that the dist files have this at the very top. super handy to know which version you're running! since you deleted it here, i'll make this the blocking request.
There was a problem hiding this comment.
Will add it programmatically with the gulp command
| @@ -0,0 +1,39 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
a readme update AND a new example - nice job!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #76