Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 77: Provide additional parameters to map.title.content #80

Merged
merged 4 commits into from
Jul 12, 2018
Merged

Conversation

melalj
Copy link
Member

@melalj melalj commented Jul 11, 2018

Related to #77 (PR compares with branch dev-76)
Need to merge PR #79 first

Copy link
Contributor

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We deleted package-lock.json back in #73 - we should keep it deleted I think, yeah? Let's remove it and add it to the .gitignore so it doesn't get added again.

@melalj
Copy link
Member Author

melalj commented Jul 12, 2018

@Ths2-9Y-LqJt6 The package-lock.json helps to lock the versions for the project - and the documents says we need to commit it to the version control.
You need to update to npm5+ (node 8) to be able to support it.

@melalj melalj merged commit aeb1cb5 into dev-76 Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants