[Optimizer]: add quick gelu fusion pass for ViT model. #9718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenshen36
requested review from
zhupengyang,
hong19860320 and
liyancas
as code owners
|
Thanks for your contribution! |
|
|
stevenshen36
force-pushed
the
quick_gelu_passes_new
branch
3 times, most recently
from
a2a25a4
to
45b5712
Compare
zhupengyang
reviewed
Nov 21, 2022
stevenshen36
force-pushed
the
quick_gelu_passes_new
branch
2 times, most recently
from
5a95eb8
to
94a0e00
Compare
stevenshen36
force-pushed
the
quick_gelu_passes_new
branch
from
94a0e00
to
24268eb
Compare
|
LGTM |
zhupengyang
approved these changes
Nov 22, 2022
Comment on lines
+39
to
+40
| bool has_act = const_cast<Node*>(node)->AsStmt().op_info()->HasAttr( | ||
| "activation_type"); |
There was a problem hiding this comment.
node->stmt()
尽量不要用 const_cast
| } | ||
|
|
||
| cpp::OpDesc GenOpDesc(const key2nodes_t& matched) { | ||
| auto op_desc = *matched.at("scale")->stmt()->op_info(); |
There was a problem hiding this comment.
两个算子的定义完全不同，没必要复用 op_info。更好的做法是新建一个 OpInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.