Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap NCE to python #7723

Merged
merged 5 commits into from
Jan 23, 2018
Merged

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 22, 2018

And write an unittest for it

Also fix #7728

And write an unittest for it
@reyoung reyoung requested a review from wanghaoshuang January 22, 2018 05:50
wanghaoshuang
wanghaoshuang previously approved these changes Jan 22, 2018
Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* also div num_samples when return cost of nce_op
@reyoung reyoung merged commit b455502 into PaddlePaddle:develop Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCE op not reset d_x to zero when backward
2 participants