Make Parallel.Do support sparse gradients #7754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyyang-svail
commented
Jan 23, 2018
| @@ -270,6 +270,7 @@ def get_parameters(self): | |||
| for in_var_name in op.input(iname): | |||
| if in_var_name not in local_inputs: | |||
| params.append(in_var_name) | |||
| params = list(set(params)) | |||
There was a problem hiding this comment.
@reyoung Duplications of the parameter names will be taken care by backward. parallel_do only needs a unique list.
|
Excellent PR. I will look at it today. |
reyoung
previously approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7724
depends on #7723