Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypicking GH-10923 to PaddleOCR:dygraph #11069

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Cherrypicking GH-10923 to PaddleOCR:dygraph #11069

merged 1 commit into from
Oct 13, 2023

Conversation

itasli
Copy link
Contributor

@itasli itasli commented Oct 12, 2023 •
edited
Loading

PR types

  • Bug fixes

PR changes

  • Others

Description

  • Fix split function where it failed to correctly set paths on different platform

Check-list

  • This PR is pushed to the dygraph branch or cherry-picked from the dygraph branch. Otherwise, please push your changes to the dygraph branch.
  • This PR have fully described what it does such that reviewers can speedup.
  • This PR can be covered by current tests or already test locally by you.

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2023

Thanks for your contribution!

@itasli itasli mentioned this pull request Oct 12, 2023
Closed
shiyutang
shiyutang approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiaXiao243 JiaXiao243 merged commit 2213807 into PaddlePaddle:dygraph Oct 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shiyutang shiyutang shiyutang approved these changes

Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itasli @shiyutang @JiaXiao243