Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored splitTrainVal and added multiOS path support #10923

Closed
wants to merge 1 commit into from
Closed

refactored splitTrainVal and added multiOS path support #10923

wants to merge 1 commit into from

Conversation

itasli
Copy link
Contributor

@itasli itasli commented Sep 17, 2023

No description provided.

@andyjiang1116
Copy link
Collaborator

@itasli could you explain your PR ? I'm confused about what you have changed?

@itasli
Copy link
Contributor Author

itasli commented Oct 10, 2023

Hey @andyjpaddle , basically I changed this :

imagePath = os.path.join(dataAbsPath, "{}\\{}".format(args.recImageDirName, imageName))

to this :

image_path = os.path.join(data_abs_path, args.recImageDirName, image_name)

I don't really remember well but i had some issue using the split function on either windows or ubuntu and had to modifiy the code to make it word, other changes are just refactoring

@shiyutang
Copy link
Collaborator

Hi, Could you please push your changes to the dygraph branch.

@itasli
Copy link
Contributor Author

itasli commented Oct 12, 2023

Hi, Could you please push your changes to the dygraph branch.

here it is GH-11069

@shiyutang
Copy link
Collaborator

shiyutang commented Oct 16, 2023

This PR has been merged into develop. Therefore close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants