Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty on Service.SupportHours and Service.ScheduledActions #351

Closed
wants to merge 1 commit into from

Conversation

theckman
Copy link
Collaborator

The lack of omitempty on these fields is causing CreateService calls to fail
when both are omitted. This broke in the v1.4.0 release so this is a bug fix.

Relates to #348

Fixes #346

The lack of `omitempty` on these fields is causing `CreateService` calls to fail
when both are omitted. This broke in the v1.4.0 release so this is a bug fix.

Relates to #348

Fixes #346
@theckman theckman added this to the v1.4.2 milestone Aug 30, 2021
@theckman theckman closed this Aug 30, 2021
@theckman theckman removed this from the v1.4.2 milestone Aug 30, 2021
@theckman theckman deleted the fix_CreateService branch August 31, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backward incompatability - CreateService - existing setup works in 1.3.0 but not in 1.4.x
1 participant