-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should all fields in Service type be `omitempty #348
Comments
@callumj for For the other fields it seems like more of an accidental omission within the package. We should probably fix those with the similar issues we're hoping to address in |
Change of plans, going to fix this in |
Slight correction, I'll fix the things that broke in |
@callumj Actually, would you be wiling to raise a PR with Because of how the repo is configured, I can't merge my own PRs without getting a review from a PD employee when they have a spare moment. Those spare cycles can be hard to come by, unfortunately. I can review and merge the PRs of others, and so if you could raise a PR, and have a moment to address any feedback, it would be a tremendous help in getting this change made. If not no sweat! |
I am trying to just change the
alert_creation
type on a service (viaUpdateService
) and have noticed I cannot just set it as the JSON marshal wants to includeauto_resolve_timeout
,acknowledgement_timeout
,escalation_policy
(it isn't a pointer soomitempty
doesn't work),support_hours
,scheduled_actions
.Is there a reason a few of these are lacking
omitempty
?The text was updated successfully, but these errors were encountered: