Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty JSON tag to specific Service fields #384

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Conversation

theckman
Copy link
Collaborator

Providing these fields on updates is optional, and so we should totally emit
them if they are empty versus accidentally unsetting them by sending a null
value.

Closes #348

Providing these fields on updates is optional, and so we should totally emit
them if they are empty versus accidentally unsetting them by sending a `null`
value.

Closes #348
@theckman theckman added this to the v1.5.0 milestone Nov 12, 2021
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should all fields in Service type be `omitempty
2 participants