Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADMIN REDESIGN: redesign the Event Management's Registrant tab for the talawa Admin portal #1750

Open
aashimawadhwa opened this issue Mar 19, 2024 · 30 comments
Assignees
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@aashimawadhwa
Copy link
Member

aashimawadhwa commented Mar 19, 2024

Is your feature request related to a problem? Please describe.
we are planning redesigning the admin portal, this issue is a part of that redesigning flow.

Describe the solution you'd like
we want to redesign the Event Management Registrant Tab for the talawa Admin portal

  • we want to club show registrant and check-ins registrant in a single parent tab i.e registrant
  • The show registrant is ready for now please leave check-in registrant button non functional for now.
  • After clicking on the add registrant button , the registrant should dissapper from this screen after a react toast with success message.

Screenshots

  • Attaching the screenshots for reference.

Current Situation:
Screenshot 2024-03-20 at 12 22 18 AM

Desired Result:
Screenshot 2024-03-20 at 12 17 14 AM

Related Issues:

#1748

Please refer the figma file for a detailed understanding :
https://www.figma.com/file/WksD4uIa5sQJMIk3pR4l0c/Talawa-Design-System-(Official)?type=design&node-id=3447%3A59&mode=design&t=fkgMPaaz67qLwmMz-1

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI parent Parent issue unapproved labels Mar 19, 2024
@aashimawadhwa aashimawadhwa changed the title ADMIN REDESIGN: redesign the Event Management Registrant tab for the talawa Admin portal ADMIN REDESIGN: redesign the Event Management's Registrant tab for the talawa Admin portal Mar 19, 2024
@Sahi1l-Kumar
Copy link

Can I get this issue assigned? I currently have 2 pull requests under review. I know the policy is to have only 2 issues assigned but since this issue is not getting traction I can work on it.

@Cioppolo14
Copy link

@Sahi1l-Kumar Thank you for your enthusiasm. We do our best to stick with the 2 issue policy unless there is an important exception. I will work on getting your PRs reviewed soon. Thank you for understanding.

@MahendraDani
Copy link
Contributor

@Cioppolo14 Should I work on this?

@palisadoes
Copy link
Contributor

We are tracking this issue with one of our projects, and we'd like to track its progress especially as the GSoC announcement dates draw near.

  1. When you create your PR, please link it back to this project:
    1. https://github.com/orgs/PalisadoesFoundation/projects/27/views/1
  2. The process is simple. It can be found here:
    1. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar

@MahendraDani
Copy link
Contributor

@aashimawadhwa @palisadoes would you please explain the following:

Current Situation:

image

The above screen is shown when we click on Show Registrants button in the event dashbaord.

image

The above screen is shown when we click on Check-In Registrants button in the event dashboard.

Expected Situation:

image

As I have understood the scope of this issue, we have to update the screens(modals) mentioned in Current Situation section above with the new design screens (tables).
Furthermore, we have to combine Show Registrants and Check-In Registrants button into one single button named Registrants.(This is to be displayed in top navbar)

1

  • Please refer to the highlighted section in red color

And below the top navbar, we have to provider two buttons Check-In Registrants and All Registrants which will change the list of registrants based on their check-in status.

2

  • Please refer to the highlighted section in yellow color

Please let me know if I am missing any detail.
Thank you

@palisadoes
Copy link
Contributor

Go ahead

@MahendraDani
Copy link
Contributor

ok

@palisadoes
Copy link
Contributor

Unassigning. 12 days without activity or PR

@Sahi1l-Kumar
Copy link

Please assign this issue to me

@Sahi1l-Kumar
Copy link

Will be working on this passively as I have my exams. Apologies for the delay.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 27, 2024
@Sahi1l-Kumar
Copy link

I think the Add Registrant column should be in a different Non-Registrants table.
The All Registrants table should have Remove Registrant option instead. What are your thoughts @palisadoes ?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 29, 2024
@palisadoes
Copy link
Contributor

Please work with @aashimawadhwa on this.

@Sahi1l-Kumar Sahi1l-Kumar removed their assignment May 17, 2024
@AnshulKahar2729
Copy link

@palisadoes I would like to work on this issue.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 29, 2024
@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
@duplixx duplixx reopened this Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in 2024 New Talawa Admin Screens Nov 11, 2024
@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 12, 2024
@syedali237
Copy link

Can I be assigned this issue?

@duplixx
Copy link
Member

duplixx commented Nov 19, 2024

@syedali237, what's the update on this issue? It's an important functionality that needs to be done for the MVP functionality to be working fine.

@syedali237
Copy link

Working on it, would need some more time.

@duplixx
Copy link
Member

duplixx commented Nov 24, 2024

@syedali237 what's the update on this, if you facing any blockers please share it here

@syedali237
Copy link

@duplixx wanted to clarify a few things. Do I need to redesign the entire event management portal or simply add sections for "Check-in" and "All Registrants"? Here’s the current layout of the event management portal for reference: (if am looking at the wrong place, please can you correct me and guide me through it)

Screenshot 2024-11-23 at 1 24 24 PM

@duplixx
Copy link
Member

duplixx commented Nov 24, 2024

@syedali237, you don't need to redesign the whole thing. You just need to add check-in, all registrations, and a table of registrants to this tab. Refer to the existing people screen or attendance screen, or you can directly refer to the Figma design that was shared earlier.

@syedali237
Copy link

@duplixx I’ve created the basic structure of the EventRegistrants component for now. I have a couple of questions regarding the implementation:
Since there is no separate collection for event registrations, and the data comes from the eventAttendance collection, should I filter users with isRegistered = true to display them as All Registrants? Similarly, for "Check-In Registrants," should I filter users with isCheckedIn = true?
Could you guide me on what the AddRegistrants button should direct to?

Screenshot 2024-11-25 at 4 47 29 AM

@duplixx
Copy link
Member

duplixx commented Nov 27, 2024

@syedali237
Great, the design looks good.
Check-in registrants should open up a modal where the volunteer can check in participants by searching for their names.(the modal is already built see addRegistrantWrapper.tsx)
The functionality of the Add Registrants button is similar to the Check-in button, as it will essentially add registrants to the attendees list.

@duplixx
Copy link
Member

duplixx commented Dec 1, 2024

@syedali237 whats the update, if its done please raise the PR

@syedali237
Copy link

@duplixx Still working on it and need a bit more time. I’ll have it completed and raise the PR within this week.

@syedali237
Copy link

@duplixx I have implemented the "Add Registrant" functionality by adding EventRegistrationWrapper.tsx. However, I am currently encountering an issue while working on the "Check-In" functionality. Specifically, I am trying to add CheckInWrapper.tsx so that it is triggered when the "Check-In Registrant" button is clicked. Unfortunately, when I attempt to implement this, the web app crashes. Could you please assist me in identifying and resolving the issue?

Screenshot 2024-12-05 at 11 20 13 PM

This particular line of code is causing issue . Removing this line, the code works perfectly fine.

1733422095619389.mp4

@duplixx
Copy link
Member

duplixx commented Dec 6, 2024

@syedali237 Check-In registrant and Add Registrants should work separately, you can go with custom function for add registrants

@syedali237
Copy link

I have implemented all the functionality and features for this component. Will raise the PR after writing tests for the component.

1733829955762569.mp4

@duplixx
Copy link
Member

duplixx commented Dec 11, 2024

@syedali237 looks good

@palisadoes
Copy link
Contributor

  1. Please use the new universal stylesheet when creating the PR.
  2. We are moving towards a color blind friendly design that the CSS supports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: In progress
Development

No branches or pull requests

8 participants