Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp & Refac Event Management Dashboard & Sidebar #1878

Merged
merged 7 commits into from
Apr 6, 2024

Conversation

GlenDsza
Copy link

@GlenDsza GlenDsza commented Apr 5, 2024

What kind of change does this PR introduce?

Screen Redesign, refactoring

Issue Number:

Fixes #1748 & #1853

Did you add tests for your changes?

Yes

  • Event Management:
    image

  • Event Management Dashboard:
    image

  • EventHeader.tsx:
    image

Snapshots/Videos:

event.management.mp4

Summary

  • Remove the old EventLeftDrawer and EventLeftDrawerWrapper.
  • Redesigned Event Management Screen & Added new svg files
  • Add new Tab Layout in Event Management Screen to enable switching with ease.
  • Fixed UI issues related to Event Drawer.
  • Refac EventListCard.test.tsx
  • Add test coverage for all the new files.

Other information

Will affect following issues as base structure for Event Management screen is changed:
#1752, #1751, #1750

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Apr 5, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@GlenDsza GlenDsza changed the title Revamp & Refac Event Management Screen & Sidebar Revamp & Refac Event Management Dashboard & Sidebar Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (99e6195) to head (eb7d71f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1878   +/-   ##
========================================
  Coverage    98.34%   98.35%           
========================================
  Files          199      198    -1     
  Lines         5074     5039   -35     
  Branches      1486     1465   -21     
========================================
- Hits          4990     4956   -34     
+ Misses          79       78    -1     
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

Thanks. Please fix the conflicting file so that we can merge.

@GlenDsza
Copy link
Author

GlenDsza commented Apr 5, 2024

@palisadoes have fixed the merge conflicts

@Cioppolo14
Copy link

@ttaylor92 @tasneemkoushar Can you review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants