-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp & Refac Event Management Dashboard & Sidebar #1878
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1878 +/- ##
========================================
Coverage 98.34% 98.35%
========================================
Files 199 198 -1
Lines 5074 5039 -35
Branches 1486 1465 -21
========================================
- Hits 4990 4956 -34
+ Misses 79 78 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Thanks. Please fix the conflicting file so that we can merge. |
@palisadoes have fixed the merge conflicts |
@ttaylor92 @tasneemkoushar Can you review this PR? |
01272f7
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Screen Redesign, refactoring
Issue Number:
Fixes #1748 & #1853
Did you add tests for your changes?
Yes
Event Management:
Event Management Dashboard:
EventHeader.tsx:
Snapshots/Videos:
event.management.mp4
Summary
EventLeftDrawer
andEventLeftDrawerWrapper
.EventListCard.test.tsx
Other information
Will affect following issues as base structure for Event Management screen is changed:
#1752, #1751, #1750
Have you read the contributing guide?
Yes