-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: Write Tests for graphql_config.dart #2298
Fixes: Write Tests for graphql_config.dart #2298
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2298 +/- ##
===========================================
+ Coverage 88.27% 92.23% +3.95%
===========================================
Files 155 157 +2
Lines 7352 7508 +156
===========================================
+ Hits 6490 6925 +435
+ Misses 862 583 -279 ☔ View full report in Codecov by Sentry. |
* test for individual post screen written * removed pubspec.lock * fix falling test case" * removed pubspec.lock * Comprehensive Language Translation Enhancement for App Globalization (#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations * Bump tj-actions/changed-files from 35 to 41 in /.github/workflows (#2302) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add: GraphQl Test (#2298) * Update pull-request.yml * fix failing test case * added pubspec.lock from develop * removed pubspec.lock * lock file * Comprehensive Language Translation Enhancement for App Globalization (#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations * fix * fix * fix * fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ayush Raghuwanshi <62144720+AyushRaghuvanshi@users.noreply.github.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com>
* test for individual post screen written * removed pubspec.lock * fix falling test case" * removed pubspec.lock * Comprehensive Language Translation Enhancement for App Globalization (PalisadoesFoundation#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations * Bump tj-actions/changed-files from 35 to 41 in /.github/workflows (PalisadoesFoundation#2302) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add: GraphQl Test (PalisadoesFoundation#2298) * Update pull-request.yml * fix failing test case * added pubspec.lock from develop * removed pubspec.lock * lock file * Comprehensive Language Translation Enhancement for App Globalization (PalisadoesFoundation#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations * fix * fix * fix * fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ayush Raghuwanshi <62144720+AyushRaghuvanshi@users.noreply.github.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com>
What kind of change does this PR introduce?
Issue Number: #2159
Fixes #2159
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Upon Checking the code coverage this MockHttpClient was missing the test. I wrote a test for it. Since the endpoint does not exist and MockHttpClient is designed to throw 500. We always receive null in the data. For which I have tested it out.
Does this PR introduce a breaking change?
No.
Have you read the contributing guide?
Yes