test for individual post screen written #2300

AVtheking · 2024-01-02T14:53:23Z

What kind of change does this PR introduce?

I have written test for individual_post.dart

Issue Number:

Fixes #2148

Did you add tests for your changes?
Yes

github-actions · 2024-01-02T14:53:51Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov · 2024-01-02T15:01:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7852f5) 94.02% compared to head (c7d55b2) 94.58%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2300      +/-   ##
===========================================
+ Coverage    94.02%   94.58%   +0.55%     
===========================================
  Files          157      157              
  Lines         7533     7533              
===========================================
+ Hits          7083     7125      +42     
+ Misses         450      408      -42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dante291 · 2024-01-02T16:01:50Z

You don't need to push your pubspec.lock file for the test.

AVtheking · 2024-01-02T18:18:28Z

I have removed pubspec.llock file

noman2002 · 2024-01-03T04:52:12Z

@AVtheking Its not removed yet. Please have a look and fix the failing test.

AVtheking · 2024-01-03T06:07:16Z

When I removed the pubspec.lock file then it was failing test

AVtheking · 2024-01-03T15:28:50Z

Please review it an suggest changes if any

…alisadoesFoundation#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations

…lisadoesFoundation#2302) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

palisadoes · 2024-01-04T18:40:31Z

@AVtheking please work with the reviewers to get this approved.
I won't be revisiting it

AVtheking · 2024-01-05T03:19:57Z

@palisadoes ok sir

AVtheking · 2024-01-05T16:20:58Z

@Ayush0Chaudhary @literalEval please review it and suggest changes if any so that I can
work on more issues

noman2002 · 2024-01-06T18:37:05Z

@AVtheking Revert the changes in pubspec.lock. Its not required.

Ayush0Chaudhary

if you dont know how to remove change in lock file

copy the lock file from develop file on github and paste it in you IDE and make a new commit

Ayush0Chaudhary · 2024-01-02T16:29:46Z

pubspec.lock

+  leak_tracker:
+    dependency: transitive
+    description:
+      name: leak_tracker
+      sha256: "41b90ceaec6d79819f31e975e61d479516efe701dea35f891b2f986c1b031422"
+      url: "https://pub.dev"
+    source: hosted
+    version: "9.0.17"
+  leak_tracker_flutter_testing:
+    dependency: transitive
+    description:
+      name: leak_tracker_flutter_testing
+      sha256: "54808cfcfa87dbc0d74c61ac063d624adf1bd5c0407301f32b06c783c60dc4ca"
+      url: "https://pub.dev"
+    source: hosted
+    version: "2.0.0"
+  leak_tracker_testing:
+    dependency: transitive
+    description:
+      name: leak_tracker_testing
+      sha256: "7e71be3c161472f6c9158ac8875dd8de575060d60b5d159ebca3600ea32c9116"
+      url: "https://pub.dev"
+    source: hosted
+    version: "1.0.6"


I have copied the lock file from develop branch

literalEval · 2024-01-07T19:27:13Z

pubspec.lock

@@ -1899,4 +1899,4 @@ packages:
    version: "3.1.2"
 sdks:
  dart: ">=3.2.0 <3.13.0"
-  flutter: ">=3.16.0"
+  flutter: ">=3.16.0"


Why is this a change ? Did you add or remove the EOF line ?

No I do not remove or add the EOF line

Maybe it is because I have taken the lock file from develop branch and pasted in my branch

You can try merging your branch with develop. Remove the pubspec in a commit, merge with develop, and the do the final push. That should do. Also, it's a nice strategy to keep merging with develop to avoid these conflicts here.

I have done merging with develop but still this change is showing

…alisadoesFoundation#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations

Dante291 · 2024-01-09T14:35:53Z

just manually add EOL in pubspec file and commit

AVtheking · 2024-01-09T14:41:13Z

I have added EOL still showing change in that file

literalEval

LGTM

palisadoes · 2024-01-10T15:23:20Z

Please fix conflicting file. Regenerate if necessary

AVtheking · 2024-01-10T16:17:28Z

I have fixed the conflicts please review it

* test for individual post screen written * removed pubspec.lock * fix falling test case" * removed pubspec.lock * Comprehensive Language Translation Enhancement for App Globalization (PalisadoesFoundation#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations * Bump tj-actions/changed-files from 35 to 41 in /.github/workflows (PalisadoesFoundation#2302) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add: GraphQl Test (PalisadoesFoundation#2298) * Update pull-request.yml * fix failing test case * added pubspec.lock from develop * removed pubspec.lock * lock file * Comprehensive Language Translation Enhancement for App Globalization (PalisadoesFoundation#2290) * Comprehensive Language Translation Enhancement for App Globalization * adding more translations * testing * test * test * test * proper format for translation files * formating * formating * formating * fixing translation * fixing linting errors * writing test for missing lines * writing test for missing lines * writing test for missing lines * fixing translations * fixing translations * fixing translations * fixing translations * fix * fix * fix * fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ayush Raghuwanshi <62144720+AyushRaghuvanshi@users.noreply.github.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com>

test for individual post screen written

c277f9e

palisadoes requested review from Ayush0Chaudhary and literalEval January 2, 2024 16:11

removed pubspec.lock

b45b2b1

fix falling test case"

477ec4a

removed pubspec.lock

0b81dfb

Dante291 and others added 5 commits January 4, 2024 23:33

Add: GraphQl Test (PalisadoesFoundation#2298)

4bc2544

Update pull-request.yml

50f3ca4

fix failing test case

d270c05

AVtheking requested a review from palisadoes as a code owner January 4, 2024 18:03

Merge branch 'develop' into fix/individual_post_screen_test

5244bde

palisadoes removed their request for review January 4, 2024 18:40

Ayush0Chaudhary reviewed Jan 6, 2024

View reviewed changes

added pubspec.lock from develop

2124a06

AVtheking requested a review from Ayush0Chaudhary January 7, 2024 11:54

literalEval reviewed Jan 7, 2024

View reviewed changes

Merge branch 'develop' into fix/individual_post_screen_test

e37c3ac

AVtheking and others added 6 commits January 9, 2024 19:43

removed pubspec.lock

1eddad0

lock file

7e6acee

fix

e98141d

fix

701623b

fix

3cc697f

fix

55ce6b8

AVtheking requested a review from literalEval January 9, 2024 18:34

literalEval previously approved these changes Jan 10, 2024

View reviewed changes

Merge branch 'develop' into fix/individual_post_screen_test

c7d55b2

AVtheking dismissed literalEval’s stale review via c7d55b2 January 10, 2024 16:15

palisadoes approved these changes Jan 10, 2024

View reviewed changes

palisadoes merged commit 928f616 into PalisadoesFoundation:develop Jan 10, 2024
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test for individual post screen written #2300

test for individual post screen written #2300

AVtheking commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

codecov bot commented Jan 2, 2024 •

edited

Loading

Dante291 commented Jan 2, 2024 •

edited

Loading

AVtheking commented Jan 2, 2024

noman2002 commented Jan 3, 2024

AVtheking commented Jan 3, 2024

AVtheking commented Jan 3, 2024

palisadoes commented Jan 4, 2024

AVtheking commented Jan 5, 2024

AVtheking commented Jan 5, 2024

noman2002 commented Jan 6, 2024

Ayush0Chaudhary left a comment

Ayush0Chaudhary Jan 2, 2024

AVtheking Jan 6, 2024

literalEval Jan 7, 2024

AVtheking Jan 7, 2024

AVtheking Jan 8, 2024

literalEval Jan 9, 2024

AVtheking Jan 9, 2024

AVtheking Jan 9, 2024

Dante291 commented Jan 9, 2024

AVtheking commented Jan 9, 2024

literalEval left a comment

palisadoes commented Jan 10, 2024

AVtheking commented Jan 10, 2024

test for individual post screen written #2300

test for individual post screen written #2300

Conversation

AVtheking commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

codecov bot commented Jan 2, 2024 • edited Loading

Codecov Report

Dante291 commented Jan 2, 2024 • edited Loading

AVtheking commented Jan 2, 2024

noman2002 commented Jan 3, 2024

AVtheking commented Jan 3, 2024

AVtheking commented Jan 3, 2024

palisadoes commented Jan 4, 2024

AVtheking commented Jan 5, 2024

AVtheking commented Jan 5, 2024

noman2002 commented Jan 6, 2024

Ayush0Chaudhary left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dante291 commented Jan 9, 2024

AVtheking commented Jan 9, 2024

literalEval left a comment

Choose a reason for hiding this comment

palisadoes commented Jan 10, 2024

AVtheking commented Jan 10, 2024

codecov bot commented Jan 2, 2024 •

edited

Loading

Dante291 commented Jan 2, 2024 •

edited

Loading