written test for post_modal.dart #2304

AVtheking · 2024-01-03T14:53:03Z

What kind of change does this PR introduce?
Written test for post modal widget

Issue Number:

Fixes #2150

Did you add tests for your changes?

Yes

github-actions · 2024-01-03T14:53:29Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov · 2024-01-03T15:01:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (803bfd5) 93.64% compared to head (a2f6f95) 94.02%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2304      +/-   ##
===========================================
+ Coverage    93.64%   94.02%   +0.38%     
===========================================
  Files          157      157              
  Lines         7533     7533              
===========================================
+ Hits          7054     7083      +29     
+ Misses         479      450      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

noman2002 · 2024-01-06T18:33:47Z

lib/widgets/post_modal.dart

                            onPressed: () {
                              Navigator.pop(context);
                            },


These lines are missing. Please write the test for it.

https://app.codecov.io/gh/PalisadoesFoundation/talawa/pull/2304/blob/lib/widgets/post_modal.dart

I have written test for these lines also

literalEval · 2024-01-06T21:34:42Z

lib/widgets/post_modal.dart

@@ -89,6 +91,7 @@ class PostBottomModal extends StatelessWidget {
                        ),
                        actions: <Widget>[
                          TextButton(
+                            key: const Key('yes'),


Give a descriptive name to the key.

literalEval · 2024-01-06T21:34:48Z

lib/widgets/post_modal.dart

@@ -99,6 +102,7 @@ class PostBottomModal extends StatelessWidget {
                            child: const Text("Yes"),
                          ),
                          TextButton(
+                            key: const Key('no'),


I have provided them more descriptive name

literalEval · 2024-01-06T21:35:28Z

pubspec.lock

@@ -1013,6 +1013,30 @@ packages:
      url: "https://pub.dev"
    source: hosted
    version: "6.7.1"
+  leak_tracker:


What is this package and why is it added ?

literalEval · 2024-01-06T21:35:45Z

test/widget_tests/widgets/post_modal_test.dart

+  likedBy: likeby,
+  comments: comments1,
+);
+Widget createPostBottomModal() {


Add new lines to make the code more readable.

AVtheking · 2024-01-07T04:28:32Z

I have added pubspec.lock file from develop branch

literalEval · 2024-01-07T08:39:31Z

@AVtheking in that case, try merging with develop instead. You don't need to add files like that.

AVtheking · 2024-01-07T09:01:06Z

Like what I have to do ? Pull the code from develop branch into this branch then commit ?

AVtheking · 2024-01-07T09:03:36Z

I have just take the code of lock file from develop branch and pasted in my file so that there is no changes from develop branch ,ig merging with develop will result in same

literalEval · 2024-01-07T19:21:09Z

Get latest pull of develop in your local code. Then switch to this branch and do "git merge develop". Please look into basic git strategies.

* created settings page * formatted the code * fixed failing tests * resolved requested changes * fixed failing tests

* Created Test * Updated Formatting

* fixed events fetching bug * fixed failing tests * added comments to event_queries * fixed failing test

…undation#2306) * Refactor: Decouple ViewModel by Moving UI Logic to View * refactoring app_settings_view_model and app_seetings_page * writing test for missing lines

…2257) * feature: Removed all references to Google firebase * formatted firebase_mocks.dart * removed ignore directive for custom lint rule * formatted login_view_model file * removal of commented code * removed fcmToken test * avoid dynamic calls check passed * format check * fixed linting issue * added documentation for event_queries file * format check

…sFoundation#2315) Bumps [syncfusion_flutter_datepicker](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.1.43 to 24.1.44. - [Release notes](https://github.com/syncfusion/flutter-widgets/releases) - [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages) --- updated-dependencies: - dependency-name: syncfusion_flutter_datepicker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…oundation#2314) Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.0/packages/url_launcher) --- updated-dependencies: - dependency-name: url_launcher_platform_interface dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [image_picker](https://github.com/flutter/packages/tree/main/packages/image_picker) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/image_picker-v1.0.6/packages/image_picker) --- updated-dependencies: - dependency-name: image_picker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [video_player](https://github.com/flutter/packages/tree/main/packages/video_player) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/video_player-v2.8.2/packages/video_player) --- updated-dependencies: - dependency-name: video_player dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [google_maps_flutter](https://github.com/flutter/packages/tree/main/packages/google_maps_flutter) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/google_maps_flutter-v2.5.1/packages/google_maps_flutter) --- updated-dependencies: - dependency-name: google_maps_flutter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

AVtheking · 2024-01-08T11:18:46Z

Now I have merged develop branch into this branch ,please review the changes

palisadoes · 2024-01-08T16:35:25Z

Please fix the failing tests

AVtheking · 2024-01-09T18:35:54Z

I have fixed the failing test please review it and suggest any changes if any so that I can work on more issues

literalEval

LGTM.

literalEval · 2024-01-10T14:03:09Z

pubspec.lock

@@ -1843,4 +1843,4 @@ packages:
    version: "3.1.2"
 sdks:
  dart: ">=3.2.0 <3.13.0"
-  flutter: ">=3.16.0"
+  flutter: ">=3.16.0"


Not entirely sure about this EOF line. Commenting just in case.

* written test for post_modal.dart * written the missing test * descriptive name to the key * fix failing test * created settings page (PalisadoesFoundation#2299) * created settings page * formatted the code * fixed failing tests * resolved requested changes * fixed failing tests * rebased * descriptive name to the key * Select contact test (PalisadoesFoundation#2301) * Created Test * Updated Formatting * fixed fetch events bug (PalisadoesFoundation#2308) * fixed events fetching bug * fixed failing tests * added comments to event_queries * fixed failing test * Refactor: Decouple ViewModel by Moving UI Logic to View (PalisadoesFoundation#2306) * Refactor: Decouple ViewModel by Moving UI Logic to View * refactoring app_settings_view_model and app_seetings_page * writing test for missing lines * fix: Removed all references to Google firebase (PalisadoesFoundation#2257) * feature: Removed all references to Google firebase * formatted firebase_mocks.dart * removed ignore directive for custom lint rule * formatted login_view_model file * removal of commented code * removed fcmToken test * avoid dynamic calls check passed * format check * fixed linting issue * added documentation for event_queries file * format check * Bump syncfusion_flutter_datepicker from 24.1.43 to 24.1.44 (PalisadoesFoundation#2315) Bumps [syncfusion_flutter_datepicker](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.1.43 to 24.1.44. - [Release notes](https://github.com/syncfusion/flutter-widgets/releases) - [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages) --- updated-dependencies: - dependency-name: syncfusion_flutter_datepicker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump url_launcher_platform_interface from 2.2.0 to 2.3.0 (PalisadoesFoundation#2314) Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.0/packages/url_launcher) --- updated-dependencies: - dependency-name: url_launcher_platform_interface dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump image_picker from 1.0.5 to 1.0.6 (PalisadoesFoundation#2313) Bumps [image_picker](https://github.com/flutter/packages/tree/main/packages/image_picker) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/image_picker-v1.0.6/packages/image_picker) --- updated-dependencies: - dependency-name: image_picker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump video_player from 2.8.1 to 2.8.2 (PalisadoesFoundation#2317) Bumps [video_player](https://github.com/flutter/packages/tree/main/packages/video_player) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/video_player-v2.8.2/packages/video_player) --- updated-dependencies: - dependency-name: video_player dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump google_maps_flutter from 2.5.0 to 2.5.1 (PalisadoesFoundation#2316) Bumps [google_maps_flutter](https://github.com/flutter/packages/tree/main/packages/google_maps_flutter) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/google_maps_flutter-v2.5.1/packages/google_maps_flutter) --- updated-dependencies: - dependency-name: google_maps_flutter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * merged develop branch * fix * fix failing test --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Shaik Azad <120930148+Azad99-9@users.noreply.github.com> Co-authored-by: Shivam Gupta <shivamggupta2604@gmail.com> Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com> Co-authored-by: Abhishek Saini <78199221+Abhisheksainii@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

written test for post_modal.dart

324d8cd

palisadoes requested review from Ayush0Chaudhary, noman2002 and literalEval January 3, 2024 15:11

noman2002 requested changes Jan 6, 2024

View reviewed changes

written the missing test

bef405a

AVtheking requested a review from noman2002 January 6, 2024 20:02

literalEval requested changes Jan 6, 2024

View reviewed changes

descriptive name to the key

b83921a

fix failing test

742eaf7

Azad99-9 and others added 13 commits January 8, 2024 16:37

created settings page (PalisadoesFoundation#2299)

618879b

* created settings page * formatted the code * fixed failing tests * resolved requested changes * fixed failing tests

rebased

99c0d9b

descriptive name to the key

40099ff

Select contact test (PalisadoesFoundation#2301)

4deb30a

* Created Test * Updated Formatting

fixed fetch events bug (PalisadoesFoundation#2308)

066f23e

* fixed events fetching bug * fixed failing tests * added comments to event_queries * fixed failing test

Refactor: Decouple ViewModel by Moving UI Logic to View (PalisadoesFo…

733444a

…undation#2306) * Refactor: Decouple ViewModel by Moving UI Logic to View * refactoring app_settings_view_model and app_seetings_page * writing test for missing lines

merged develop branch

87a5c4e

AVtheking and others added 2 commits January 8, 2024 16:44

Merge branch 'develop' into fix/test_for_post_modal

3046abc

fix

bcb0864

AVtheking requested a review from literalEval January 8, 2024 11:18

fix failing test

a2f6f95

literalEval approved these changes Jan 10, 2024

View reviewed changes

palisadoes approved these changes Jan 10, 2024

View reviewed changes

palisadoes merged commit c7852f5 into PalisadoesFoundation:develop Jan 10, 2024
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

written test for post_modal.dart #2304

written test for post_modal.dart #2304

AVtheking commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

codecov bot commented Jan 3, 2024 •

edited

Loading

noman2002 Jan 6, 2024

noman2002 Jan 6, 2024

AVtheking Jan 6, 2024

literalEval Jan 6, 2024

literalEval Jan 6, 2024

AVtheking Jan 7, 2024

literalEval Jan 6, 2024

literalEval Jan 6, 2024

AVtheking commented Jan 7, 2024

literalEval commented Jan 7, 2024 •

edited

Loading

AVtheking commented Jan 7, 2024

AVtheking commented Jan 7, 2024

literalEval commented Jan 7, 2024

AVtheking commented Jan 8, 2024

palisadoes commented Jan 8, 2024

AVtheking commented Jan 9, 2024

literalEval left a comment

literalEval Jan 10, 2024

written test for post_modal.dart #2304

written test for post_modal.dart #2304

Conversation

AVtheking commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

codecov bot commented Jan 3, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AVtheking commented Jan 7, 2024

literalEval commented Jan 7, 2024 • edited Loading

AVtheking commented Jan 7, 2024

AVtheking commented Jan 7, 2024

literalEval commented Jan 7, 2024

AVtheking commented Jan 8, 2024

palisadoes commented Jan 8, 2024

AVtheking commented Jan 9, 2024

literalEval left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2024 •

edited

Loading

literalEval commented Jan 7, 2024 •

edited

Loading