Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Decouple ViewModel by Moving UI Logic to View #2306

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Refactor: Decouple ViewModel by Moving UI Logic to View #2306

merged 4 commits into from
Jan 6, 2024

Conversation

Dante291
Copy link

@Dante291 Dante291 commented Jan 4, 2024

What kind of change does this PR introduce?

Refactoring the UI logic from Profile_page_view_model to profile_page.

Issue Number:

Fixes #2303

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

No

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d95344) 92.37% compared to head (0620512) 92.37%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2306      +/-   ##
===========================================
- Coverage    92.37%   92.37%   -0.01%     
===========================================
  Files          158      158              
  Lines         7632     7631       -1     
===========================================
- Hits          7050     7049       -1     
  Misses         582      582

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dante291
Copy link
Author

Dante291 commented Jan 4, 2024

@palisadoes @noman2002 @Cioppolo14 please assign reviewers.

@Dante291
Copy link
Author

Dante291 commented Jan 4, 2024

@palisadoes this PR which recently got merged moved the Logout user logic from profile_page_view_model to app_setting_view_model but issue still persists i.e. app_setting_view_model still has UI logic which should be in app_setting_page so im gonna fix that in this PR only.

@Dante291
Copy link
Author

Dante291 commented Jan 6, 2024

@noman2002 review please

noman2002
noman2002 approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@Dante291
Copy link
Author

Dante291 commented Jan 6, 2024

@palisadoes please review and if fine please merge so that i could work on other issues. Thanks

@palisadoes palisadoes merged commit 6ac0633 into PalisadoesFoundation:develop Jan 6, 2024
7 checks passed
AVtheking pushed a commit to AVtheking/talawa that referenced this pull request Jan 8, 2024
@Dante291 @AVtheking
Refactor: Decouple ViewModel by Moving UI Logic to View (PalisadoesFo…
733444a 
…undation#2306)

* Refactor: Decouple ViewModel by Moving UI Logic to View

* refactoring app_settings_view_model and app_seetings_page

* writing test for missing lines
palisadoes pushed a commit that referenced this pull request Jan 10, 2024
@AVtheking @Azad99-9
@imshivam-gupta @Dante291 @Abhisheksainii @dependabot
written test for post_modal.dart (#2304)
c7852f5 
* written test for post_modal.dart

* written the missing test

* descriptive name to the key

* fix failing test

* created settings page (#2299)

* created settings page

* formatted the code

* fixed failing tests

* resolved requested changes

* fixed failing tests

* rebased

* descriptive name to the key

* Select contact test (#2301)

* Created Test

* Updated Formatting

* fixed fetch events bug (#2308)

* fixed events fetching bug

* fixed failing tests

* added comments to event_queries

* fixed failing test

* Refactor: Decouple ViewModel by Moving UI Logic to View (#2306)

* Refactor: Decouple ViewModel by Moving UI Logic to View

* refactoring app_settings_view_model and app_seetings_page

* writing test for missing lines

* fix: Removed all references to Google firebase (#2257)

* feature: Removed all references to Google firebase

* formatted firebase_mocks.dart

* removed ignore directive for custom lint rule

* formatted login_view_model file

* removal of commented code

* removed fcmToken test

* avoid dynamic calls check passed

* format check

* fixed linting issue

* added documentation for event_queries file

* format check

* Bump syncfusion_flutter_datepicker from 24.1.43 to 24.1.44 (#2315)

Bumps [syncfusion_flutter_datepicker](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.1.43 to 24.1.44.
- [Release notes](https://github.com/syncfusion/flutter-widgets/releases)
- [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages)

---
updated-dependencies:
- dependency-name: syncfusion_flutter_datepicker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump url_launcher_platform_interface from 2.2.0 to 2.3.0 (#2314)

Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.0/packages/url_launcher)

---
updated-dependencies:
- dependency-name: url_launcher_platform_interface
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump image_picker from 1.0.5 to 1.0.6 (#2313)

Bumps [image_picker](https://github.com/flutter/packages/tree/main/packages/image_picker) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/image_picker-v1.0.6/packages/image_picker)

---
updated-dependencies:
- dependency-name: image_picker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump video_player from 2.8.1 to 2.8.2 (#2317)

Bumps [video_player](https://github.com/flutter/packages/tree/main/packages/video_player) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/video_player-v2.8.2/packages/video_player)

---
updated-dependencies:
- dependency-name: video_player
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google_maps_flutter from 2.5.0 to 2.5.1 (#2316)

Bumps [google_maps_flutter](https://github.com/flutter/packages/tree/main/packages/google_maps_flutter) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/google_maps_flutter-v2.5.1/packages/google_maps_flutter)

---
updated-dependencies:
- dependency-name: google_maps_flutter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* merged develop branch

* fix

* fix failing test

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Shaik Azad <120930148+Azad99-9@users.noreply.github.com>
Co-authored-by: Shivam Gupta <shivamggupta2604@gmail.com>
Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com>
Co-authored-by: Abhishek Saini <78199221+Abhisheksainii@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
@Dante291
Refactor: Decouple ViewModel by Moving UI Logic to View (PalisadoesFo…
9105162 
…undation#2306)

* Refactor: Decouple ViewModel by Moving UI Logic to View

* refactoring app_settings_view_model and app_seetings_page

* writing test for missing lines
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
@AVtheking @Azad99-9
@imshivam-gupta @Dante291 @Abhisheksainii @dependabot
written test for post_modal.dart (PalisadoesFoundation#2304)
f2d69d8 
* written test for post_modal.dart

* written the missing test

* descriptive name to the key

* fix failing test

* created settings page (PalisadoesFoundation#2299)

* created settings page

* formatted the code

* fixed failing tests

* resolved requested changes

* fixed failing tests

* rebased

* descriptive name to the key

* Select contact test (PalisadoesFoundation#2301)

* Created Test

* Updated Formatting

* fixed fetch events bug (PalisadoesFoundation#2308)

* fixed events fetching bug

* fixed failing tests

* added comments to event_queries

* fixed failing test

* Refactor: Decouple ViewModel by Moving UI Logic to View (PalisadoesFoundation#2306)

* Refactor: Decouple ViewModel by Moving UI Logic to View

* refactoring app_settings_view_model and app_seetings_page

* writing test for missing lines

* fix: Removed all references to Google firebase (PalisadoesFoundation#2257)

* feature: Removed all references to Google firebase

* formatted firebase_mocks.dart

* removed ignore directive for custom lint rule

* formatted login_view_model file

* removal of commented code

* removed fcmToken test

* avoid dynamic calls check passed

* format check

* fixed linting issue

* added documentation for event_queries file

* format check

* Bump syncfusion_flutter_datepicker from 24.1.43 to 24.1.44 (PalisadoesFoundation#2315)

Bumps [syncfusion_flutter_datepicker](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.1.43 to 24.1.44.
- [Release notes](https://github.com/syncfusion/flutter-widgets/releases)
- [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages)

---
updated-dependencies:
- dependency-name: syncfusion_flutter_datepicker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump url_launcher_platform_interface from 2.2.0 to 2.3.0 (PalisadoesFoundation#2314)

Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.0/packages/url_launcher)

---
updated-dependencies:
- dependency-name: url_launcher_platform_interface
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump image_picker from 1.0.5 to 1.0.6 (PalisadoesFoundation#2313)

Bumps [image_picker](https://github.com/flutter/packages/tree/main/packages/image_picker) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/image_picker-v1.0.6/packages/image_picker)

---
updated-dependencies:
- dependency-name: image_picker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump video_player from 2.8.1 to 2.8.2 (PalisadoesFoundation#2317)

Bumps [video_player](https://github.com/flutter/packages/tree/main/packages/video_player) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/video_player-v2.8.2/packages/video_player)

---
updated-dependencies:
- dependency-name: video_player
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google_maps_flutter from 2.5.0 to 2.5.1 (PalisadoesFoundation#2316)

Bumps [google_maps_flutter](https://github.com/flutter/packages/tree/main/packages/google_maps_flutter) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/google_maps_flutter-v2.5.1/packages/google_maps_flutter)

---
updated-dependencies:
- dependency-name: google_maps_flutter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* merged develop branch

* fix

* fix failing test

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Shaik Azad <120930148+Azad99-9@users.noreply.github.com>
Co-authored-by: Shivam Gupta <shivamggupta2604@gmail.com>
Co-authored-by: Parag Gupta <103507835+Dante291@users.noreply.github.com>
Co-authored-by: Abhishek Saini <78199221+Abhisheksainii@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayush0Chaudhary Ayush0Chaudhary Ayush0Chaudhary approved these changes

@noman2002 noman2002 noman2002 approved these changes

@literalEval literalEval Awaiting requested review from literalEval

@Kevoniat Kevoniat Awaiting requested review from Kevoniat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: ViewModel should not have code for View.
4 participants
@Dante291 @noman2002 @Ayush0Chaudhary @palisadoes