Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/jsonschema #18

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Feat/jsonschema #18

merged 4 commits into from
Jan 3, 2023

Conversation

willemgovaerts
Copy link
Contributor

The package class-validator has a vulnerability as detected by snyk (SNYK-JS-CLASSVALIDATOR-1730566). To remedy this, it has to be upgraded to version 0.14.0.
However, this causes the package class-validator-jsonschema to crash since this uses internals of class-validator which are not backwards compatible between the two versions. I have an open PR to update the actual package. But since there hasn't been any response on this it seemed best to incorporate this (small) package in Papi.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023


=============================== Coverage summary ===============================
Statements   : 96.53% ( 474/491 )
Branches     : 83.82% ( 228/272 )
Functions    : 94.52% ( 138/146 )
Lines        : 97.45% ( 421/432 )
================================================================================

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023


=============================== Coverage summary ===============================
Statements   : 96.53% ( 474/491 )
Branches     : 83.82% ( 228/272 )
Functions    : 94.52% ( 138/146 )
Lines        : 97.45% ( 421/432 )
================================================================================

@willemgovaerts willemgovaerts requested a review from ljobse January 3, 2023 08:42
@willemgovaerts willemgovaerts merged commit 05920bb into main Jan 3, 2023
@willemgovaerts willemgovaerts deleted the feat/jsonschema branch January 3, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants