Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded version of class-validator #95

Merged

Conversation

willemgovaerts
Copy link
Contributor

The private fields constraintMetadatas and validationMetadatas of MetadataStorage have changed from an array to a map in version 0.14.0 of class-transformer. This PR adds support for version 0.14.0 to class-validator-jsonschema.

Copy link

@invakid404 invakid404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these changes locally in a project of mine, they work perfectly, looking forward to this PR getting merged :^)

@AnthonyDugarte
Copy link

Please merge this

@willemgovaerts
Copy link
Contributor Author

Sorry, didn't mean to re-request review and I don't know how to cancel it.

@ljobse
Copy link

ljobse commented Jan 2, 2023

@epiphone Could you get this merged and released?

package.json Outdated Show resolved Hide resolved
__tests__/customValidation.test.ts Outdated Show resolved Hide resolved
src/options.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #95 (454f915) into master (625eb19) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          199       199           
  Branches        54        54           
=========================================
  Hits           199       199           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epiphone epiphone changed the title upgraded version of class-transformer upgraded version of class-validator Jan 7, 2023
@epiphone epiphone merged commit 59b3799 into epiphone:master Jan 7, 2023
@epiphone
Copy link
Owner

epiphone commented Jan 7, 2023

Released in https://github.com/epiphone/class-validator-jsonschema/releases/tag/v4.0.0.

@willemgovaerts willemgovaerts deleted the feat/update-class-transformer branch January 10, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants