-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OriginatingHostId
and ProcessingHostId
headers that represent the current "host"
#1905
Comments
@andreasohlund @yvesgoeleven does this cover what we discussed? |
@andreasohlund - this does not seem to allign with what we discussed in Particular/ServiceControl#180 also - changing the headers wil afect everything in SI in non backwards compatible way. Has this been considered ? |
@dannycohen that is the reason why is assigned to v4.4 |
We need to keep Headers.ProcessingEndpoint since that is the endpoint name which is still valid in azure. Regarding machine: We need to do this in a backwards compatible way (goes with out saying) so the header will stay for one more major version |
But shouldn't the Headers.ProcessingEndpoint contains the endpoint instance On Thursday, 16 January 2014, Andreas Öhlund notifications@github.com
|
Well, we need to know the endpoint that it belongs to as well. So either 2 On Thu, Jan 16, 2014 at 10:34 AM, John Simons notifications@git.luolix.topwrote:
|
We can do that since the endpoint instance includes the name On Thursday, 16 January 2014, Andreas Öhlund notifications@github.com
|
Can we really assume that? Especially if we allow users to override? On Thu, Jan 16, 2014 at 11:05 AM, John Simons notifications@git.luolix.topwrote:
|
Implemented as part of #1913 |
We currently have the
ProcessingMachine
andOriginatingMachine
headers. These do not accurately reflect all concepts of a "Host". For example when hosting in Azure.So the headers
OriginatingHostId
,HostId
andHostDisplayName
have been added to be environment agnostic where "machine" does not make sense.The headers
ProcessingMachine
andOriginatingMachine
have been marked as obsolete and will be removed in 5.0.The text was updated successfully, but these errors were encountered: