Make sure transport operations do not share mutable state between multiple routing strategies #6905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
unicast-outbox
branch
from
bd5a875
to
161923c
Compare
danielmarbach
changed the title
timbussmann
approved these changes
Nov 3, 2023
danielmarbach
added a commit
that referenced
this pull request
Nov 3, 2023
…tiple routing strategies (#6905) * Add routing to dispatch connector tests to reproduce the shared state problem * Fix the state sharing problem in ToTransportOperation * Cross check headers and properties * Test for the header modifications in the routing strategy * add acceptance test * better naming and comments * block scoped namespace * Remove left overs * Move test * Primary ctor * Behavior --------- Co-authored-by: Tim Bussmann <timbussmann@users.noreply.github.com>
danielmarbach
added a commit
that referenced
this pull request
Nov 3, 2023
…tiple routing strategies (#6905) * Add routing to dispatch connector tests to reproduce the shared state problem * Fix the state sharing problem in ToTransportOperation * Cross check headers and properties * Test for the header modifications in the routing strategy * add acceptance test * better naming and comments * block scoped namespace * Remove left overs * Move test * Primary ctor * Behavior --------- Co-authored-by: Tim Bussmann <timbussmann@users.noreply.github.com>
|
@SzymonPobiega FYI |
danielmarbach
added a commit
that referenced
this pull request
Nov 3, 2023
…tiple routing strategies (#6905) (#6909) * Add routing to dispatch connector tests to reproduce the shared state problem * Fix the state sharing problem in ToTransportOperation * Cross check headers and properties * Test for the header modifications in the routing strategy * add acceptance test * better naming and comments * block scoped namespace * Remove left overs * Move test * Primary ctor * Behavior --------- Co-authored-by: Tim Bussmann <timbussmann@users.noreply.github.com>
danielmarbach
added a commit
that referenced
this pull request
Nov 3, 2023
…tiple routing strategies (#6905) (#6910) * Add routing to dispatch connector tests to reproduce the shared state problem * Fix the state sharing problem in ToTransportOperation * Cross check headers and properties * Test for the header modifications in the routing strategy * add acceptance test * better naming and comments * block scoped namespace * Remove left overs * Move test * Primary ctor * Behavior --------- Co-authored-by: Tim Bussmann <timbussmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6906