Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining the outbox with a message-driven transport may lead to message loss when publishing to multiple subscribers #6910

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

danielmarbach
Copy link
Contributor

Backport of #6905 to release-8.0

…tiple routing strategies (#6905)

* Add routing to dispatch connector tests to reproduce the shared state problem

* Fix the state sharing problem in ToTransportOperation

* Cross check headers and properties

* Test for the header modifications in the routing strategy

* add acceptance test

* better naming and comments

* block scoped namespace

* Remove left overs

* Move test

* Primary ctor

* Behavior

---------

Co-authored-by: Tim Bussmann <timbussmann@users.noreply.github.com>
@danielmarbach danielmarbach added this to the 8.0.8 milestone Nov 3, 2023
@danielmarbach danielmarbach changed the title Make sure transport operations do not share mutable state between multiple routing strategies Combining the outbox with message-driven transport may lead to message loss on publish to multiple subscribers Nov 3, 2023
@danielmarbach danielmarbach merged commit 9dab85f into release-8.0 Nov 3, 2023
3 checks passed
@danielmarbach danielmarbach deleted the backport-unicast-outbox-r80 branch November 3, 2023 15:12
Copy link
Member

@SzymonPobiega SzymonPobiega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmarbach danielmarbach changed the title Combining the outbox with message-driven transport may lead to message loss on publish to multiple subscribers Combining the outbox with a message-driven transport may lead to message loss when publishing to multiple subscribers Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants