[i18n] Don't translate terms_of_use_url #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat
changed the title
tstirrat
added
the
translation
* develop: (24 commits) Translation to Brazilian Portuguese (#614) Italian language updates (#626) Remove authority selection from onboarding (#679) v1.0.0 (#669) Hide unintented "What does this mean?" message (#668) BUGFIX: Add authority wasn't immediate (#667) Polish the EULA (#666) Add in a 6 hour time period between notifications (#665) Add an EULA to the onboarding process (#638) change to rawcdn for the versions.yaml file (#662) Change naming in yaml, change yaml link (#661) Add version check service (#653) Add healthcare selection to onboarding flow (#657) Add yaml file for version checking (#658) Fix languages specific for history page (#628) Lokalise: Translations update (ht) (#655) Temporarily filter out extra languages in release mode (#654) Suggest screenshots and fixed issues in PR template (#637) Fix settings locale override storage (#649) Disable google import on release builds (#651) ...
Patrick-Erichsen
approved these changes
Apr 25, 2020
Yeah, it sounds like we'll need language settings payloads somewhere re mayo clinic too. But configuring the app in lokalise seems weird too. |
tstirrat
added a commit
that referenced
this pull request
Apr 28, 2020
* develop: Fix "plural" keys, add i18n checks for new PRs (#648) Auto add authorities (#587) Clean up more eslint issues (#678) Make nav back arrow color theme aware (#686) yarn run-ios now runs pod install (#681) Fix settings icon on iOS 12, replace with new icon (#687) Feature/creole tests (#690) Fix formatting EULAs (#671) [i18n] Don't translate terms_of_use_url (#642) Fix background to run to edge of screen on iOS (#682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
terms_of_use_urlfrom i18n, and move to functional + hooks + TypographyHow to test
Check screenshot, looks the same: