Fix some numbering and formatting problems on en and ht EULAs #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat
approved these changes
Apr 25, 2020
tstirrat
added a commit
that referenced
this pull request
Apr 28, 2020
* develop: Fix "plural" keys, add i18n checks for new PRs (#648) Auto add authorities (#587) Clean up more eslint issues (#678) Make nav back arrow color theme aware (#686) yarn run-ios now runs pod install (#681) Fix settings icon on iOS 12, replace with new icon (#687) Feature/creole tests (#690) Fix formatting EULAs (#671) [i18n] Don't translate terms_of_use_url (#642) Fix background to run to edge of screen on iOS (#682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the numbering so it didn't restart halfway through counting, removed the list nesting in the English EULA, and cleaned up both files a bit.
Linked issues:
None that I'm aware of.
Screenshots:
How to test
I don't think much testing is necessary since I just changed the HTML strings, but a visual scan to make sure there aren't any weird display problems in the HTML would be good