Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) #672 - remove confusing error logging in Google import #703

Merged
merged 6 commits into from
May 1, 2020
Merged

(Fix) #672 - remove confusing error logging in Google import #703

merged 6 commits into from
May 1, 2020

Conversation

ten-sis
Copy link
Contributor

@ten-sis ten-sis commented Apr 28, 2020 •
edited by tstirrat
Loading

What's done:

  • Remove excessive logging caused confusion in ticket Errors importing Google Location History #672. The import is actually completed successfully
  • Add an error message in case of denied access if Take out is opened from other than Google Drive folder

Linked issues:

Fixes #672

Screenshots:

Screen Shot 2020-04-27 at 11 06 31 PM

How to test

To verify import is successful:

  1. Upload google takeout file
  2. Go to import screen
  3. Click "import locations"
  4. You should see the success message and no errors in the console

To check out access denied error message (Android only):

  1. Download Take out file in browser from google drive mobile site
  2. Go to import screen
  3. Click "import locations"
  4. Select Take out file from Downloads folder

@ten-sis ten-sis changed the title (Fix) #672 - remove excessive logging (Fix) #672 - remove confusing error logging in Google import Apr 28, 2020
tstirrat
tstirrat suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@tstirrat tstirrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

app/locales/en.json Show resolved Hide resolved
app/views/Import.js Outdated Show resolved Hide resolved
@sergesemashko
Copy link
Contributor

Additional screenshots:
Screen Shot 2020-04-08 at 5 39 29 PM
Screen Shot 2020-04-08 at 5 37 41 PM
Screen Shot 2020-04-08 at 5 37 35 PM
Screen Shot 2020-04-08 at 5 13 34 PM
Screen Shot 2020-04-08 at 5 09 09 PM
Screen Shot 2020-04-29 at 10 20 05 PM

@sergesemashko
Copy link
Contributor

@tstirrat , thanks for reviewing the PR. I incorporated the feedback, could you re-review?

tstirrat
tstirrat reviewed Apr 30, 2020
View reviewed changes
app/views/Import.js Outdated
}
} catch (err) {
if (err instanceof NoRecentLocationsError) {
setImportResults(
makeImportResults('label.import_no_recent_locations', true),
makeImportResults(
languages.t('import.google.no_recent_locations'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use t() (the useTranslation hook) and remove languages.t() here and through the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're there, setImportResults is always called with makeImportResults, perhaps they can be moved one into the other method?

tstirrat
tstirrat suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@tstirrat tstirrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits, and we're good to go.

@sergesemashko
Copy link
Contributor

@tstirrat , good catch, thanks. The PR is updated, please re-review

@tstirrat tstirrat merged commit ba75fed into Path-Check:develop May 1, 2020
tstirrat added a commit to eyganeshv/covid-safe-paths that referenced this pull request May 1, 2020
@tstirrat
Merge branch 'develop' into pr/eyganeshv/521
c61f562 
* develop:
  Update dev README (Path-Check#705)
  Better error logging in Google import (Path-Check#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724)
  Translation refresh (Path-Check#708)
  updated issue template (Path-Check#729)
tstirrat added a commit that referenced this pull request May 2, 2020
@tstirrat
Merge branch 'develop' into ts-icon-button
0a217c8 
* develop:
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
tstirrat added a commit that referenced this pull request May 2, 2020
@tstirrat
Merge branch 'develop' into ts-theme-button
4b91a3e 
* develop: (60 commits)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
  Remove react-native-maps (#695)
  ...
tstirrat added a commit that referenced this pull request May 3, 2020
@tstirrat
Merge branch 'develop' into ts-feature-flags
a14deaa 
* develop:
  Add language contribution info to contributing guide (#754)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
tstirrat added a commit that referenced this pull request May 4, 2020
@tstirrat
Merge branch 'develop' into ts-eula-i18n
6f8fbc2 
* develop:
  Build time feature flags (Phase 1) (#694)
  Extract theme aware <IconButton /> component (#756)
  Latest i18n pull (#755)
  Add language contribution info to contributing guide (#754)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
aputinski pushed a commit to safe-paths-contrib/covid-safe-paths that referenced this pull request May 6, 2020
Merge remote-tracking branch 'official/develop' into survey
734ad7a 
* official/develop: (110 commits)
  Consolidate to a single theme aware Button component (Path-Check#767)
  Fixed incorrect pull command. (Path-Check#769)
  Update README, etc for tripleblind -> Path-Check (Path-Check#768)
  HTML EULA translation workflow (Path-Check#710)
  Allowing setup on macOS/Darwin for Android only. (Path-Check#766)
  Add Danish to the list of languages. (Path-Check#765)
  Fixed the aspect ration on the icon and add links (Path-Check#763)
  Build time feature flags (Phase 1) (Path-Check#694)
  Extract theme aware <IconButton /> component (Path-Check#756)
  Latest i18n pull (Path-Check#755)
  Add language contribution info to contributing guide (Path-Check#754)
  Recommend PR best practices in PR template (Path-Check#750)
  Add eslint react-hooks checks (Path-Check#751)
  iOS: Added local notification in terminate function. (Path-Check#521)
  Update dev README (Path-Check#705)
  Better error logging in Google import (Path-Check#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724)
  Translation refresh (Path-Check#708)
  updated issue template (Path-Check#729)
  Set up location after skiping the steps (Path-Check#721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstirrat tstirrat tstirrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors importing Google Location History
3 participants
@ten-sis @sergesemashko @tstirrat