Allowing setup on macOS/Darwin for Android only. #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option to dev_setup.sh, --skip-ios, to skip configuration related to iOS. If Xcode is not installed, configuring without this option is not allowed. ### Testing Notes ### Please run ./dev-setup.sh on a Mac without Xcode. Result should be: Xcode must be installed to develop for iOS. Use option '--skip-ios' to setup development for Android only. (exit code 1) Add option --skip-ios and script should complete setting up development for Android only. Please run ./dev-setup on Mac _with_ Xcode and the script should run like before and setup for both Android and iOS development. ### Fixed Issues ### Setup script dev_setup.sh failed on macOS/Darwin if tools for iOS development were not installed.
tstirrat
approved these changes
May 5, 2020
|
Thanks! |
aputinski
pushed a commit
to safe-paths-contrib/covid-safe-paths
that referenced
this pull request
May 6, 2020
* official/develop: (110 commits) Consolidate to a single theme aware Button component (Path-Check#767) Fixed incorrect pull command. (Path-Check#769) Update README, etc for tripleblind -> Path-Check (Path-Check#768) HTML EULA translation workflow (Path-Check#710) Allowing setup on macOS/Darwin for Android only. (Path-Check#766) Add Danish to the list of languages. (Path-Check#765) Fixed the aspect ration on the icon and add links (Path-Check#763) Build time feature flags (Phase 1) (Path-Check#694) Extract theme aware <IconButton /> component (Path-Check#756) Latest i18n pull (Path-Check#755) Add language contribution info to contributing guide (Path-Check#754) Recommend PR best practices in PR template (Path-Check#750) Add eslint react-hooks checks (Path-Check#751) iOS: Added local notification in terminate function. (Path-Check#521) Update dev README (Path-Check#705) Better error logging in Google import (Path-Check#703) Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724) Translation refresh (Path-Check#708) updated issue template (Path-Check#729) Set up location after skiping the steps (Path-Check#721) ...
monaabd27
pushed a commit
to monaabd27/covid-safe-paths
that referenced
this pull request
May 18, 2020
New option to dev_setup.sh, --skip-ios, to skip configuration related to iOS. If Xcode is not installed, configuring without this option is not allowed. ### Testing Notes ### Please run ./dev-setup.sh on a Mac without Xcode. Result should be: Xcode must be installed to develop for iOS. Use option '--skip-ios' to setup development for Android only. (exit code 1) Add option --skip-ios and script should complete setting up development for Android only. Please run ./dev-setup on Mac _with_ Xcode and the script should run like before and setup for both Android and iOS development. ### Fixed Issues ### Setup script dev_setup.sh failed on macOS/Darwin if tools for iOS development were not installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option to dev_setup.sh, --skip-ios, to skip configuration related to iOS.
If Xcode is not installed, configuring without this option is not allowed.
Testing Notes
Please run ./dev-setup.sh on a Mac without Xcode. Result should be:
Xcode must be installed to develop for iOS.
Use option '--skip-ios' to setup development for Android only.
(exit code 1)
Add option --skip-ios and script should complete setting up
development for Android only.
Please run ./dev-setup on Mac with Xcode and the script should run
like before and setup for both Android and iOS development.
Fixed Issues
Setup script dev_setup.sh failed on macOS/Darwin if tools for iOS
development were not installed.