Skip to content

Commit

Permalink
Material remove (#613)
Browse files Browse the repository at this point in the history
* Remove material2 and simplify html and css

* add form back to home

* add exterior state back to app

* add about content back in

* update e2e test
  • Loading branch information
ebeal committed May 19, 2016
1 parent ddec25a commit 4e4f719
Show file tree
Hide file tree
Showing 14 changed files with 45 additions and 196 deletions.
1 change: 0 additions & 1 deletion config/webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ module.exports = {
exclude: [
// these packages have problems with their sourcemaps
helpers.root('node_modules/rxjs'),
helpers.root('node_modules/@angular2-material'),
helpers.root('node_modules/@angular'),
]
}
Expand Down
1 change: 0 additions & 1 deletion config/webpack.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ module.exports = {
exclude: [
// these packages have problems with their sourcemaps
helpers.root('node_modules/rxjs'),
helpers.root('node_modules/@angular2-material'),
helpers.root('node_modules/@angular')
]}

Expand Down
12 changes: 0 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,6 @@

},
"dependencies": {
"@angular2-material/button": "2.0.0-alpha.4",
"@angular2-material/card": "2.0.0-alpha.4",
"@angular2-material/checkbox": "2.0.0-alpha.4",
"@angular2-material/icon": "2.0.0-alpha.4",
"@angular2-material/core": "2.0.0-alpha.4",
"@angular2-material/input": "2.0.0-alpha.4",
"@angular2-material/list": "2.0.0-alpha.4",
"@angular2-material/progress-bar": "2.0.0-alpha.4",
"@angular2-material/progress-circle": "2.0.0-alpha.4",
"@angular2-material/radio": "2.0.0-alpha.4",
"@angular2-material/sidenav": "2.0.0-alpha.4",
"@angular2-material/toolbar": "2.0.0-alpha.4",
"@angular/http": "2.0.0-rc.1",
"@angular/common": "2.0.0-rc.1",
"@angular/compiler": "2.0.0-rc.1",
Expand Down
26 changes: 10 additions & 16 deletions src/app/about/about.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,18 @@ console.log('`About` component loaded asynchronously');
@Component({
selector: 'about',
styles: [`
h1 {
font-family: Arial, Helvetica, sans-serif
}
md-card{
margin: 25px;
}
`],
template: `
<md-card>
For hot module reloading run
<pre>npm run start:hmr</pre>
</md-card>
<md-card>
<h3>
patrick@AngularClass.com
</h3>
</md-card>
<h1>About</h1>
<div>
For hot module reloading run
<pre>npm run start:hmr</pre>
</div>
<div>
<h3>
patrick@AngularClass.com
</h3>
</div>
`
})
export class About {
Expand Down
36 changes: 10 additions & 26 deletions src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,37 +19,21 @@ import { RouterActive } from './router-active';
directives: [ RouterActive ],
encapsulation: ViewEncapsulation.None,
styles: [
require('normalize.css'),
require('./app.css')
],
template: `
<md-content>
<md-toolbar color="primary">
<span>{{ name }}</span>
<span class="fill"></span>
<button md-button router-active [routerLink]=" ['Index'] ">
Index
</button>
<button md-button router-active [routerLink]=" ['Home'] ">
Home
</button>
<button md-button router-active [routerLink]=" ['About'] ">
About
</button>
</md-toolbar>
<md-progress-bar mode="indeterminate" color="primary" *ngIf="loading"></md-progress-bar>
<button router-active [routerLink]=" ['Index'] ">
Index
</button>
<button router-active [routerLink]=" ['Home'] ">
Home
</button>
<button router-active [routerLink]=" ['About'] ">
About
</button>
<router-outlet></router-outlet>
<pre class="app-state">this.appState.state = {{ appState.state | json }}</pre>
<footer>
<img [src]="angularclassLogo" width="6%">
WebPack Angular 2 Starter by <a [href]="url">@AngularClass</a>
</footer>
</md-content>
`
`
})
@RouteConfig([
{ path: '/', name: 'Index', component: Home, useAsDefault: true },
Expand Down
34 changes: 2 additions & 32 deletions src/app/app.css
Original file line number Diff line number Diff line change
@@ -1,34 +1,4 @@
html, body{
height: 100%;
background: #F4FAFA;
}
button.active{
background: #fff;
color: #009688;
}
button.active:hover{
color: #fff;
}
.fill{
flex: 1 1 auto;
}
.app-state{
margin: 15px;
flex: 1;
}
.home{
flex: 1;
}
md-content{
display: flex;
flex-direction: column;
height: 100%;
}
footer{
flex: 0 0 60px;
padding: 10px;
display: flex;
align-items: center;
justify-content: center;
background: #fff;
}
font-family: Arial, Helvetica, sans-serif
}
14 changes: 7 additions & 7 deletions src/app/app.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@ describe('App', () => {
expect(subject).toEqual(result);
});

it('should have <header>', () => {
let subject = element(by.css('app header')).isPresent();
it('should have header', () => {
let subject = element(by.css('h1')).isPresent();
let result = true;
expect(subject).toEqual(result);
});

it('should have <main>', () => {
let subject = element(by.css('app main')).isPresent();
it('should have <home>', () => {
let subject = element(by.css('app home')).isPresent();
let result = true;
expect(subject).toEqual(result);
});

it('should have <footer>', () => {
let subject = element(by.css('app footer')).getText();
let result = 'WebPack Angular 2 Starter by @AngularClass';
it('should have buttons', () => {
let subject = element(by.css('button')).getText();
let result = 'Index';
expect(subject).toEqual(result);
});

Expand Down
15 changes: 1 addition & 14 deletions src/app/home/home.css
Original file line number Diff line number Diff line change
@@ -1,14 +1 @@
/*styles for home content only*/
.card-container{
display: flex;
flex-direction: column;
margin: 15px;

border: 2px dashed #FBC02D;
}
.sample-content{
flex: 1;
}
.card-container md-card{
margin: 5px;
}
/*styles for home content only*/
34 changes: 14 additions & 20 deletions src/app/home/home.html
Original file line number Diff line number Diff line change
@@ -1,34 +1,28 @@
<div class="card-container">
<md-card x-large class="sample-content">Your Content Here</md-card>
<md-card>
<h1 x-large class="sample-content">Your Content Here</h1>
<div>
For hot module reloading run
<pre>npm run start:hmr</pre>
</md-card>
<md-card>
<md-card-title>Local State</md-card-title>
<md-card-content>
</div>
<div>
<h4>Local State</h4>

<form (ngSubmit)="submitState(localState.value)" autocomplete="off">
<form (ngSubmit)="submitState(localState.value)" autocomplete="off">

<md-input
placeholder="Submit Local State to App State"
[value]="localState.value"
(input)="localState.value = $event.target.value"
autofocus>
</md-input>
<input placeholder="Submit Local State to App State" [value]="localState.value" (input)="localState.value = $event.target.value"
autofocus>

<button md-raised-button color="primary">Submit Value</button>
</form>
<!--
<button md-raised-button color="primary">Submit Value</button>
</form>
<!--
<input type="text" [value]="localState.value" (input)="localState.value = $event.target.value" autofocus>
Rather than wiring up two-way data-binding ourselves with [value] and (input)
we can use Angular's [(ngModel)] syntax
<input type="text" [(ngModel)]="localState.value" autofocus>
-->

<pre>this.localState = {{ localState | json }}</pre>
<pre>this.localState = {{ localState | json }}</pre>

</md-card-content>
</md-card>
</div>

</div>
</div>
1 change: 0 additions & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
<script src="/webpack-dev-server.js"></script>
<% } %>

<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">

</body>
</html>
42 changes: 0 additions & 42 deletions src/platform/browser/angular2-material2/index.ts

This file was deleted.

7 changes: 1 addition & 6 deletions src/platform/browser/directives.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,9 @@ import { PLATFORM_DIRECTIVES } from '@angular/core';
// Angular 2 Router
import { ROUTER_DIRECTIVES } from '@angular/router-deprecated';

// Angular 2 Material 2
// TODO(gdi2290): replace with @angular2-material/all
import { MATERIAL_DIRECTIVES } from './angular2-material2';

// application_directives: directives that are global through out the application
export const APPLICATION_DIRECTIVES = [
...ROUTER_DIRECTIVES,
...MATERIAL_DIRECTIVES
...ROUTER_DIRECTIVES
];

export const DIRECTIVES = [
Expand Down
5 changes: 0 additions & 5 deletions src/platform/browser/providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,13 @@ import { HTTP_PROVIDERS } from '@angular/http';
// Angular 2 Router
import { ROUTER_PROVIDERS } from '@angular/router-deprecated';

// Angular 2 Material
// TODO(gdi2290): replace with @angular2-material/all
import { MATERIAL_PROVIDERS } from './angular2-material2';

/*
* Application Providers/Directives/Pipes
* providers/directives/pipes that only live in our browser environment
*/
export const APPLICATION_PROVIDERS = [
...FORM_PROVIDERS,
...HTTP_PROVIDERS,
...MATERIAL_PROVIDERS,
...ROUTER_PROVIDERS,
{provide: LocationStrategy, useClass: HashLocationStrategy }
];
Expand Down
13 changes: 0 additions & 13 deletions src/vendor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,6 @@ import '@angular/router-deprecated';
import 'rxjs/add/operator/map';
import 'rxjs/add/operator/mergeMap';

// Angular 2 Material 2
import '@angular2-material/button';
import '@angular2-material/card';
import '@angular2-material/checkbox';
import '@angular2-material/sidenav';
import '@angular2-material/input';
import '@angular2-material/list';
import '@angular2-material/radio';
import '@angular2-material/progress-bar';
import '@angular2-material/progress-circle';
import '@angular2-material/toolbar';
// look in src/platform/angular2-material2 and src/platform/providers

if ('production' === ENV) {
// Production

Expand Down

0 comments on commit 4e4f719

Please sign in to comment.