Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material remove #613

Merged
merged 6 commits into from
May 19, 2016
Merged

Material remove #613

merged 6 commits into from
May 19, 2016

Conversation

ebeal
Copy link
Collaborator

@ebeal ebeal commented May 19, 2016

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Remove material2 and all references from starter app
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Other information:
    Also update tests and simplify css

@PatrickJS
Copy link
Owner

LGTM

@ebeal ebeal merged commit 4e4f719 into master May 19, 2016
@ebeal ebeal deleted the materialRemove branch May 20, 2016 00:11
@IAMtheIAM
Copy link

Why did you do this? This should be reverted because it just strips down the template without benefit. I think it was cool to show off the new material design. It's easy to remove material if we don't want it, but harder to add if we do.

@JulioC
Copy link

JulioC commented May 20, 2016

I like this move, makes the example app much more concise.

I just want to understand the reasoning behind this, since even today we had commits in the direction of improving material support. Should I expect this PR to be reverted anytime soon?

@aminebizid
Copy link

Material is a part of angular for now. I don't understand this PR

@alvipeo
Copy link

alvipeo commented May 20, 2016

I actually agree with the remove. If you try to actually build a real app you can't with material. It's way too early to use it.

@dsebastien
Copy link

Ideally what we should move towards is:

  • bare project with the basic necessities
  • yeoman generators (basic, options to add material, etc)

Ideally (that's what we're doing at work):

  • externalize all the build to a separate project (i.e., make it reusable but still extensible)
  • externalize all build scripts to a CLI

But that takes some effort idd :)

@jaycangel
Copy link

Hi, can I ask why material was removed? One of the reasons i wanted to use this starter pack is because it had angular 2 and material. Is there another way you suggest I incorporate material back in?

What other css framework should we be using if not material?

@abdulhaq-e
Copy link
Contributor

mgechev's seed has a an "Examples" section where it shows forked repos that added library X to the seed

Perhaps a similar thing is needed for this seed because no seed will suite everyone!

@JulioC
Copy link

JulioC commented May 20, 2016

I believe that's the plan with the material2 branch. If kept in sync with master, that should be enough.

@IAMtheIAM
Copy link

IAMtheIAM commented May 20, 2016

Yes, please update material2 branch and this will be a fine solution to meet more dev's needs.

@jaycangel You can check out the material2 branch when its ready, or simply go to master branch, and look at previous versions of package.json and src/platform/browser/angular2-material2/index.ts

That is the most recent commit before material design was removed.

@ebeal
Copy link
Collaborator Author

ebeal commented May 20, 2016

Hey guys sorry for the lack of explanation about this. Yes the material2 branch will be kept in sync with master. The idea is to keep material separate especially while it is still unstable (while still making improvements and expanding on examples on that branch). @gdi2290 will make an update to the readme about this so people can still use that version if they like.

@shlomiassaf
Copy link
Contributor

👍

Good move, simplicity in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants