feat: add support for Angular2 Universal #1165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until univeral issue PatrickJS#686 is resolved, with the new angular2 compiler for 2.1.1
Adds polyfills to server build
|
Is this ready to be used for the latest version(2.4.1)? |
|
There is already a universal starter, adding it here would add unnecessary bloat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature - Adds angular2-universal as build-target.
What is the current behavior? (You can also link to an open issue here)
Not using Universal
Are there any plans to incorporate Angular Universal? #576
What is the new behavior (if this is a feature change)?
New build-targets (watch:universal, server:universal, build:universal).
Other information:
This is probably best put in a separate branch, as I had to downgrade to angular 2.1.0 in order to get around Fix 2.1.1 _private_ import issues angular/universal#606
Also, I made no effort to minimize code duplication, as i wanted to keep the main-line code intact, and only demonstrate how to set up a universal build of the starter.