-
Notifications
You must be signed in to change notification settings - Fork 484
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2.1.1 _private_ import issues #606
Comments
Can we merge this? Or is there any issues with this PR? |
Any news on this issue? |
I'll talk to Pat about it today and let you guys know @stanbe @AiBoy. |
Hi. Is this issue fixed? I am still getting this error, using angular2-universal version ~2.1.0-rc.1 |
@MarkPieszak I followed the link you posted and added those files to my project, and then imported the appropriate ones into my Unfortunately I'm still getting the same error. Here are my versions, if that is any help too:
|
You have it setup similar to how the starters have it? Included at the top of each of those files? @ScaryWolfMan |
@MarkPieszak Yep! :( |
It isn't working for me with 2.2.3 either. But there's a 90% chance I'm
just too tired to work on this now.
…On Wed, Dec 14, 2016, 02:25 ScaryWolfMan ***@***.***> wrote:
@MarkPieszak <https://github.com/MarkPieszak> Yep! :(
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#606 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeg9ClkQlbYh_vnaPykJvpBh2KV7nOcks5rH33JgaJpZM4KeRBn>
.
|
I'm a newibe to universal but it seems like a pretty daunting task trying to manage all the various angular projects and making sure everything works. :o |
This error is rather annoying and the workaround is by definition just a workaround, not really satisfying. Is there still an issue with the pull request? @MarkPieszak @AiBoy |
@stanbe I'm not a maintainer :/ so I can't do anything about it. And yes, we have Angular 2.3 already, but I still can't update Angular-Universal. This is sad. |
Let me make sure the workaround still works for the latest Angular release and I'll talk to @gdi2290 about it, see if it's possible to squeeze this in there! |
@MarkPieszak I've reverted to 2.10 and I'm able to run my project without any issues at the moment. |
how can we build with universal? We're started using angular2-webpack-starter |
Check out the universal node starter to see what you need to add to the webpack-starter, check out the documentation.md file here as well that talks about the necessary files. @fdambrosio |
thanks @MarkPieszak we have "Call to Node module failed with error: TypeError: Cannot read property 'SelectorMatcher' of undefined" message error |
If you're using the workaround I think you can't use Angular |
@MarkPieszak I was having the same issue, but I'm now using angular 2.1.0 and angular-universal 2.0.11. no longer getting any issues :( |
Workarounds from universal-starter repository is working well with Angular 2.4.1! |
Oh that's great news 👍 haven't been able to check on holiday this week. @dimonzav |
@dimonzav I just tried update to 2.4.1 version and adding files: __workaround.browser, __workaround.node. |
will be fixed in ng4 |
I tried the workaround. But still facing the problem in |
Do you have it setup just like in the universal starter? @ParkourKarthik |
I'm a noob and I'm using the Asp.net Core with Angular template. I faced this when I upgraded all my packages to the latest version. But now I downgraded all packages to the same in the template ( |
This template here has everything a little more up to date and is .net, take a look at the dependencies. https://github.com/MarkPieszak/aspnetcore-angular2-universal Don't worry about warnings during install for now. @ParkourKarthik |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In the latest Core/Compiler upgrades to 2.1.1, compiler-private & core-private have changed a few things Universal uses.
__compiler_private__
looks to of been removed from@angular/compiler
.SelectorMatcher & CssSelector (needed for Universal), seem to be public now.
Also
_ViewUtils
seems to be missing / removed from__core_private__
It looks like it was renamed to
view_utils
?Seems to fix it:
ViewUtils -> view_utils can be handled in a similar way.
The text was updated successfully, but these errors were encountered: