Include test utils in NPM package #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: install prb test as npm package build: install forge std as npm package build: remove gitmodules ci: install node js dependencies in build and test job chore: update remappings accordingly
andreivladbrg
force-pushed
the
build/include-test-utils-in-package
branch
from
977737d
to
233b630
Compare
|
Should I bump the package version to |
PaulRBerg
reviewed
Nov 26, 2023
PaulRBerg
reviewed
Nov 26, 2023
PaulRBerg
reviewed
Nov 26, 2023
PaulRBerg
requested changes
Nov 26, 2023
|
Thanks for the PR, Andrei.
Obviously, I haven't published the new package. The folder will exist when I publish To test what the directory structure will be in an npm package, use this command: $ npm pack --dry-run
That's fine. |
PaulRBerg
approved these changes
Dec 4, 2023
package.json
Outdated
| @@ -10,11 +10,14 @@ | |||
| "url": "https://github.com/PaulRBerg/prb-math/issues" | |||
| }, | |||
| "devDependencies": { | |||
| "@forge/std": "github:foundry-rs/forge-std#e8a047e3f40f13fa37af6fe14e6e06283d9a060e", | |||
There was a problem hiding this comment.
There's no need to use a faux @forge-std organization. We can just type it as forge-std.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
build: include test utils in package
build: install prb test as npm package
build: install forge as npm package
build: remove gitmodules
ci: install node js dependencies in build and test job
chore: update remappings accordingly
As mentioned in my comment here, importing files from the ~test/ path is not possible in the NPM package because this folder doesn't exist.
Inevitably, to make this fully compatible with the idea presented in the discussion linked above, I had to install
prb-testas an NPM package.