-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test utils in the src
dir
#206
Move test utils in the src
dir
#206
Conversation
build: install prb test as npm package build: remove prb test git module chore: update remappings accordingly
ci: install node js dependencies in test job
Context: here, Question: Should Am I missing something and we should install as NPM package like this |
Thanks @andreivladbrg, just letting you know that it will take me a while until I find the time to pick this PR up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but could you also please install Forge Std from npm?
Foundry should support nested remappings but I agree that it would be worth testing the set-up before merging this PR. |
8c304d4
to
9af9ff8
Compare
build: add peerDependencies field
9af9ff8
to
cb005a0
Compare
Addressed everything in my latest commits. |
I've changed my mind about this PR. Instead of moving the test utils in We just need to add Lines 16 to 19 in abdf0b2
|
bbf62bc
to
49f2e73
Compare
test: change path of test utils
49f2e73
to
2d2f02b
Compare
Thanks @andreivladbrg for the latest commit, but I would prefer to open a new PR to start with a clean slate! |
Clossing in favor of #211 |
Changelog:
refactor: move test utils in src dir
build: install prb test as npm package
build: remove prb test git module
ci: install node js dependencies in build and test job
chore: update remappings accordingly
As mentioned in my comment here, importing files from the
~test/
path is not possible in the NPM package because this folder doesn't exist.Inevitably, to make this fully compatible with the idea presented in the discussion linked above, I had to install
prb-test
as an NPM package.