Move test utils in the src dir #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: install prb test as npm package build: remove prb test git module build: use correct path in update-precompiles script ci: install node js dependencies in build and test job chore: update remappings accordingly
|
I see that the coverage has significantly decreased. This is because there are more contracts in Is there a way to remove a path (~src/test/) from the coverage report? |
PaulRBerg
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks Andrei, just like in PRBMath, let's install Forge Std as a Node.js dependency.
Is there a way to remove a path (~src/test/) from the coverage report?
Yes. See the codecov.yml file and the Ignoring Paths docs.
build: add peerDependencies field build: ignore src/test/ path in coverage
|
Addressed everything in my latest commits. I see that the slither job has failed and I am not sure why, is it because we need to add |
|
Thanks!
Dunno, need to investigate but cannot at the moment |
|
Closing in favor of #179 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same rationale as here
Changelog:
refactor: move test utils in src dir
build: install prb test as npm package
build: remove prb test git module
build: use correct path in update-precompiles script
ci: install node js dependencies in build test coverage job
chore: update remappings accordingly