Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_main in the CI integration tests #177

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

mattcieslak
Copy link
Contributor

In order to better estimate test coverage, try simulating the cli run

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.88%. Comparing base (df45b9d) to head (b007301).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #177       +/-   ##
===========================================
+ Coverage   33.95%   47.88%   +13.93%     
===========================================
  Files          57       57               
  Lines        7192     7192               
  Branches      983      983               
===========================================
+ Hits         2442     3444     +1002     
+ Misses       4652     3543     -1109     
- Partials       98      205      +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mattcieslak
Copy link
Contributor Author

The coverage doubles! But it makes some extra html files, which causes a failure

@tsalo tsalo added the testing label Nov 20, 2024
qsirecon/tests/test_cli.py Outdated Show resolved Hide resolved
@tsalo tsalo changed the title Directly call main() in the CI tests Disable test_main in the CI integration tests Nov 20, 2024
@tsalo tsalo merged commit 01e31d6 into main Nov 20, 2024
24 checks passed
@tsalo tsalo deleted the ci/better-coverage branch November 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants