Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usd 6554 -- Python3 shebang #1445

Closed
wants to merge 1 commit into from
Closed

Usd 6554 -- Python3 shebang #1445

wants to merge 1 commit into from

Conversation

bdeda
Copy link

@bdeda bdeda commented Feb 8, 2021

Description of Change(s)

The shebang.py uses the PYTHON_EXECUTABLE as the shebang, and uses "python" as the commands in the windows cmd files. The changes in theis PR make the PXR_PYTHON_SHEBANG settable via cmake, if the caller wants to customize that, and uses "python3" in the windows cmd files for python3 builds.

Fixes Issue(s)

Allow cmake users to specify a PXR_PYTHON_SHEBANG instead of using PYTHON_EXECUTABLE
@jilliene
Copy link

jilliene commented Feb 9, 2021

Filed as internal issue #USD-6561

@sunyab
Copy link
Contributor

sunyab commented May 15, 2021

Hi @bdeda,

  • We need a signed CLA from contributors before we can merge their pull requests in. Could you have a look at the instructions at https://graphics.pixar.com/usd/docs/Contributing-to-USD.html and submit one?

  • We're on board with allowing customization of the Python shebang as you have it. However, defaulting to python3 in the .cmd files appears to break on standard Python 3.x installs on Windows which use python.exe and not python3.exe. Would it work if we just used the shebang string passed in to the script instead of hard-coding python or python3?

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants