Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for a python instance in your path #1464

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

rstelzleni
Copy link
Contributor

Description of Change(s)

The build scripts will use the python interpreter that was used to
invoke them, rather than looking for an executable named python in the
path. Relying on python's name isn't very reliable currently. In Linux
python 3 builds the executable will be named python3, for instance.
Also, in some containerized environments python may be present with a
different name, or not be available in the path.

Fixes Issue(s)

Testing

I've done builds with this setup on a few different Mac, Windows and Linux machines. I also verified that the build succeeds in a linux docker container that only has a python3 and no python in the path

The build scripts will use the python interpreter that was used to
invoke them, rather than looking for an executable named python in the
path. Relying on python's name isn't very reliable currently. In Linux
python 3 builds the executable will be named python3, for instance.
Also, in some containerized environments python may be present with a
different name, or not be available in the path.
@tallytalwar tallytalwar self-requested a review February 25, 2021 01:18
@spiffmon
Copy link
Member

@rstelzleni , this doesn't obviate the need for Pull Request #1445, does it?

@rstelzleni
Copy link
Contributor Author

I think this is a different issue from that one. This change removes a check that seems unnecessary and that can be a nuisance in some build environments. The other one looks like its about setting up shebangs in some environments. I haven't actually ran into the issues reported there.

@jilliene
Copy link

jilliene commented Mar 2, 2021

Filed as internal issue #USD-6587

@bdeda
Copy link

bdeda commented Mar 5, 2021

This is a different issue than #1445. I am not using the python build script, so would not have come across this.

The shebang issue (1445) is in the cmake part of the builds. In our case, we are explicitly telling cmake the python executable ourselves, where this part of the python build script is trying to get that for the user.

@pixar-oss pixar-oss merged commit dd436cb into PixarAnimationStudios:dev Mar 19, 2021
@rstelzleni rstelzleni deleted the remove-python-check branch March 19, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants