Remove check for a python instance in your path #1464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The build scripts will use the python interpreter that was used to
invoke them, rather than looking for an executable named python in the
path. Relying on python's name isn't very reliable currently. In Linux
python 3 builds the executable will be named python3, for instance.
Also, in some containerized environments python may be present with a
different name, or not be available in the path.
Fixes Issue(s)
Testing
I've done builds with this setup on a few different Mac, Windows and Linux machines. I also verified that the build succeeds in a linux docker container that only has a
python3
and nopython
in the path