Snap: store media in the proper directory #695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elegaanz
added
C: Enhancement
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 39.25% 39.25%
=======================================
Files 72 72
Lines 9498 9498
Branches 2265 2265
=======================================
Hits 3728 3728
Misses 4713 4713
Partials 1057 1057 |
|
Oh, damn. I didn't push this yet! |
RAOF
requested changes
Nov 16, 2019
| @@ -45,4 +45,6 @@ then | |||
| touch ${SNAP_COMMON}/initial-migrations-run | |||
| fi | |||
|
|
|||
| mdkir "${SNAP_DATA}/media" | |||
There was a problem hiding this comment.
The configure hook gets run each time the snap is upgraded; the name might be a bit misleading. This would fail the first time the snap is upgraded, as mkdir will fail to create an existing directory.
It's also slightly misspelled 😉
|
Closing in favor of #698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't tested it, but it should be ok, if I understand how Snap works.