Various snap fixes #698
Merged
Various snap fixes #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us unconditionally run things under `set-environment` and let it handle the case where the necessary configuration hasn't yet been set.
This will make the version something like `0.3.0-alpha-2-65-g29178aa` at the moment, as that was the most recent tag, but the commit tagged as `0.4.0` will get *that* as the version
This makes building the *second* time work; otherwise there might be an existing cargo-web install, and cargo will refuse to overwrite it.
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
=======================================
Coverage 39.25% 39.25%
=======================================
Files 72 72
Lines 9498 9498
Branches 2265 2265
=======================================
Hits 3728 3728
Misses 4713 4713
Partials 1057 1057 |
igalic
approved these changes
Nov 16, 2019
| @@ -1,6 +1,6 @@ | |||
| name: plume | |||
| base: core18 | |||
| version: '0.3.0' # just for humans, typically '1.2+git' or '1.3.2' | |||
| adopt-info: plume | |||
There was a problem hiding this comment.
does Snapcraft build nightlies?
|
I *think* it's set up to build each commit. Certainly at least once a day.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new
MEDIA_UPLOAD_DIRECTORYsupport to make media uploads work, cleans up some of the scripts, and sets the version based on git tags.