-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APL solution #549
APL solution #549
Conversation
I learned my lesson to commit from losing my progress last time lol
make .sh files executable
Please:
|
I hope I fixed the Dockerfile lint errors. |
Thank you. Your solution indicates it uses one bit per prime candidate. Could you maybe talk me through how this is setup? I am rather unfamiliar with APL, but/and I don't see anything that looks like the "bit twiddling" that is required in many (if not most) other languages that don't use a specific bit-level container. |
Oops, this was a bit array in an earlier version, but I changed some operators and it was actually using an 8-bit signed integer array. I'll fix that. Anyways, with some operators, if it is creating an array of just 0s and 1s it will convert it to a bit array (this is also implementation specific). You can then use all the normal array operations on the array and as long as it only has 0s and 1s it will stay a bit array. |
Never mind, I logged the array type and it is all a bit array. |
readme stuff code is a bit better, wrote solution 2 readme started readme for solution 1 covered main function main function readme fixes optimizations, more progress on readme hopefully finished readme added output fixing readmes readme clarification clarifications removed unnecessary returns missed one clarified purpose of the bit array more clarifications added JS code fixed random indentation fixed broken js
Would it be possible to keep your fork available for some time? When I have the time, I'd like to see if I can get your solution to work with a free software version of APL. If I can get that to work, I'll open a PR on your fork so you can see if you're happy with what I've put together. What's behind this is that I really would like to add APL to the language collection. |
Yep, I'll just leave it as it is. |
Note that GNU APL is ~10-100x slower than Dyalog APL, which makes it much less suited for a performance competition. I don't think there are any free APL implementations that really focus on speed. |
@dzaima I understand that. Unfortunately, that doesn't change what we can and cannot responsibly add to this project. In any case, looking at @Garklein's last comment, it very much looks like getting their APL submission to work on GNU APL requires way more knowledge of (GNU's) APL (implementation) than I could ever dream of having. I sadly think that means that APL will not be part of the collection of languages until someone else submits an APL solution based on GNU APL, if and when that happens. |
@Garklein As discussed in the context of #722, it is now possible to add this solution, provided that the automated build/benchmark is disabled for it. This is described in the relevant section of the contributing guidelines and concerns a CI/benchmark capability that we added after you closed this PR. You can reopen your PR and add the |
Thanks for the heads up, but since Arcfide's solution is so much better, I won't open my PR. |
That's entirely your prerogative, of course. Thanks for letting us know! |
Description
Contributing requirements
drag-race
as the target branch.