feat(wip): compatibility with TH v2 #426
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change api - Add branch label to use flask db status - WIP: fix error on types medias Reviewed-by: andriacap
andriacap
force-pushed
the
feat/compatibility-taxhub-v2
branch
from
14ce844 to
ecdbc10
Compare
lpofredc
reviewed
Nov 28, 2024
| @@ -58,7 +62,7 @@ def taxhub_rest_get_all_lists() -> Optional[Dict]: | |||
| url = f"{TAXHUB_API}biblistes" | |||
| res = session.get( | |||
| url, | |||
| timeout=5, | |||
| timeout=10000, # TODO : suivant le nombre de taxons dans les listes cette requête peut êtr très longue (voir pour améliorer performance coté TaxHub avec notamment la définition dans le modèle BibListes : https://github.com/PnX-SI/TaxHub/blob/ea9434de5a1f227131e0e8640ad17f8a25e8a39d/apptax/taxonomie/models.py#L238 ) | |||
There was a problem hiding this comment.
Mëme s'il est nécessaire d'augmenter le timeout, 10000 (s) me parait énorme ;).
There was a problem hiding this comment.
Oui on peut le garder à 5 si les développements proposés coté taxhub sont accepté . Voir PR coté taxhub : PnX-SI/TaxHub#585
There was a problem hiding this comment.
C'est d'ailleurs ce qu'il y a marqué dans le TODO
lpofredc
reviewed
Nov 28, 2024
- Comment method axhub_rest_get_taxon no more used - Use function to format response from taxref - Apply black - Add todos and notes to explain code / comments Reviewed-by: andriacap
andriacap
force-pushed
the
feat/compatibility-taxhub-v2
branch
from
ecdbc10 to
45ff12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR vise à rendre compatible citizen avec la V2 de TaxHub.
Pour cela voici les tâches à réaliser :
Remplacement des appels à la route
bibnomspartaxrefGeoNature-citizen/backend/gncitizen/utils/taxonomy.py
Line 68 in 192ad3b
id_nomdoit être remplacé parcd_nompour pouvoir récupérer les informations retournées partaxrefhttps://github.com/PnX-SI/GeoNature-citizen/blob/192ad3be6d401da5135bc15b6723d9ec93d0630a/backend/gncitizen/utils/taxonomy.py#L97C4-L99C66Remplacement de la route
biblistes/taxons/<id_liste >partaxref?id_liste=<id_liste>.Récupérer les types de médias pour n'avoir que les types : media_types = ("Photo_gncitizen", "Photo_principale", "Photo"
GeoNature-citizen/backend/gncitizen/utils/taxonomy.py
Line 85 in 192ad3b
nom_type_mediasavec ("Photo_gncitizen", "Photo_principale", "Photo") .taxrefsur branche https://github.com/naturalsolutions/TaxHub/blob/fix/load_types_medias_from_taxref_route/apptax/taxonomie/routestaxref.py#L231 💡Informations annexes :
bibnomsqui est supprimé dans TH V2Reviewed-by: andriacap