Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve perf route biblistes #585

Conversation

andriacap
Copy link
Contributor

  • Load only necessary fields
  • Remove useless parameter id=None
  • Fix expression "nb_taxons" in BibListes model

See issue : #584

Reviewed-by: andriacap

- Load only necessary fields
- Remove useless parameter id=None
- Fix expression "nb_taxons" in BibListes model

Reviewed-by: andriacap
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (18b662f) to head (5a570e3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
apptax/taxonomie/routesbiblistes.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #585      +/-   ##
===========================================
+ Coverage    52.34%   52.38%   +0.04%     
===========================================
  Files           37       37              
  Lines         2432     2430       -2     
===========================================
  Hits          1273     1273              
+ Misses        1159     1157       -2     
Flag Coverage Δ
pytest 52.38% <25.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andriacap
Copy link
Contributor Author

Est ce qu'au passage il faudrait envisager de pouvoir filtrer sur id_liste et ne récupérer les infos que d'une seule liste ?

@amandine-sahl
Copy link
Contributor

Reprise dans #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants