-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: File change #61
Conversation
❌ Deploy Preview for nimble-praline-605cf6 failed.
|
Signed-off-by: Laure GAGNER <laure.gagner@epitech.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the code but be careful about the update of the content or infos of the file.
When you update the content of the file, you need to update this content to all of the users who have a shared version of the file.
Because if you want to add a feature of permissions revoke or a list of all users who have access to the shared file, you'll have a problem.
As you update the content of the file, the hash changes and you loose the trace of the shared version. So with theses features, you will not be able to get the infos about the other users who have the old version of the file.
To fix this problem, two choices:
- Update the content of the file for all of the users with the new version.
- Create a second version of the file (this version will have the new content/ infos and will not be shared).
ℹ️ The problem is just for the shared files.
Signed-off-by: Laure GAGNER <laure.gagner@epitech.eu>
5b7b42f
to
ad4927c
Compare
ad4927c
to
68b35ef
Compare
done, we chose to update the content for all users, and delete the old content only if the new upload and update is successful. |
Description
File change feature:
Allow users to change the name of a file and/or it's content.
Changes include
Checklist