Handle Brotlipy outdated hashes, option 2 (of many) - pipenv selective-upgrade #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently, #74 is blocked by the CircleCI container environment wanting to install a copy of
brotlipy-0.7.0
Python package where its SHA from upstream doesn't match any of the SHAs in the Pipfile.lock.One way to approach repairing this is explicitly installing the currently used version of brotlipy, which then adds & updates some brotlipy dependencies. This is the command used:
If we really want to restrict updates, we can pin the dependencies that are updated here (
importlib-metadata
,zipp
). I'm considering new dependencies added as okay, but open to discussion on that. I've confirmed the hashes added forbrotlipy
include all the previously-used hashes as well (you can verify by checking out thePipfile.lock
diff).Todos:
relud-patch-1
branch then proceed with the original PR (Handle shim data from GLEAN #74) - or, rebase this branch to remove therelud-patch-1
commits and merge this PR independently of Handle shim data from GLEAN #74.tests_unit
job locally to confirm this repairs the issue;Implementation Decisions
This goes the approach of using Pipenv in as restricted a way as is feasible with the tool to get the latest hashes from pypi for brotlipy version 0.7.0. Unfortunately, it seems like that involves explicitly installing brotlipy, pinned to the version used previously (determined via Pipfile.lock on main branch), and just accepting the dependencies (new & updated).
An alternative implementation to this is via this PR #77 .
All Submissions: