Handle Brotlipy outdated hashes, option 1 (of many) - manually update SHAs #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently, #74 is blocked by the CircleCI container environment wanting to install a copy of
brotlipy-0.7.0
Python package where its SHA from upstream doesn't match any of the SHAs in the Pipfile.lock.One way to approach repairing this is to manually (e.g. outside of
pipenv
) update the hashes based on the pypi API. This is the command used to get all pypi hashes forbrotlipy
version 0.7.0 (note this is taken from fishshell, and easily altered to map to bash or zsh alternatives):Those shas are then merged into the list in the
Pipfile.lock
, so all previously existing shas remain and the new ones alone are added in.Todos:
relud-patch-1
branch then proceed with the original PR (Handle shim data from GLEAN #74) - or, rebase this branch to remove therelud-patch-1
commits and merge this PR independently of Handle shim data from GLEAN #74.tests_unit
job locally to confirm this repairs the issue;Implementation Decisions
Its not great to manually update the pipenv lockfile manually like this, but it is the most minimal way to update the hashes alone without touching anything else (which Pipenv would prefer to do by its design - see linked, alternative PR).
An alternative implementation to this is via this PR #76 .
All Submissions: