Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from boost::this_thread::sleep to std::this_thread::sleep_for #2921

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Migrate from boost::this_thread::sleep to std::this_thread::sleep_for #2921

merged 4 commits into from
Mar 27, 2019

Conversation

SunBlack
Copy link
Contributor

No description provided.

@SunBlack SunBlack force-pushed the this_thread_sleep branch 2 times, most recently from 57e6024 to 396c217 Compare March 13, 2019 22:54
@taketwo taketwo added needs: code review Specify why not closed/merged yet c++14 labels Mar 15, 2019
@SergioRAgostinho
Copy link
Member

This is concurrent work with I was doing in #2700. But let's go with this, because it is done.

taketwo
taketwo requested changes Mar 16, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase on the current master? (Otherwise Windows job on CI won't pass.)

doc/tutorials/content/ground_based_rgbd_people_detection.rst Outdated Show resolved Hide resolved
doc/tutorials/content/normal_distributions_transform.rst Outdated Show resolved Hide resolved
test/io/test_grabbers.cpp Outdated Show resolved Hide resolved
@taketwo taketwo removed the needs: code review Specify why not closed/merged yet label Mar 16, 2019
@SunBlack
Copy link
Contributor Author

SunBlack commented Mar 17, 2019 •
edited
Loading

This is concurrent work with I was doing in #2700. But let's go with this, because it is done.

Sorry, I just remembered that you are working one replacing mutex from boost to std. but forgot that you wanted to change this_thread::sleep too. After my last both Boost PR I just looked for remaining posix_time occurrences (there are still some left).

@SunBlack SunBlack force-pushed the this_thread_sleep branch from 3307fdb to fb4af7c Compare March 17, 2019 15:55
@SunBlack SunBlack force-pushed the this_thread_sleep branch from fb4af7c to ebfd442 Compare March 17, 2019 17:11
taketwo
taketwo approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

SergioRAgostinho
SergioRAgostinho reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the line changes on the tutorials and I'm trusting it blindly.

visualization/tools/pcd_viewer.cpp Outdated Show resolved Hide resolved
@SergioRAgostinho
Copy link
Member

Everyone agrees on a big squash?

@taketwo taketwo merged commit 89ce7c6 into PointCloudLibrary:master Mar 27, 2019
@SunBlack SunBlack deleted the this_thread_sleep branch March 27, 2019 11:52
@taketwo taketwo mentioned this pull request Mar 29, 2019
Closed
@taketwo taketwo changed the title Replace boost::this_thread::sleep by std::this_thread::sleep_for Migrate from boost::this_thread::sleep to std::this_thread::sleep_for Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @SergioRAgostinho @taketwo